Use evalengine for Vindex lookups in route primitive #9291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systay
added
Component: Query Serving
release notes
Type: Enhancement
harshit-gangal
force-pushed
the
vindex-eval-engine
branch
from
7e52ab3
to
28d04b2
Compare
go/vt/vtgate/planbuilder/testdata/ddl_cases_no_default_keyspace.txt
Outdated
Show resolved
Hide resolved
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
…r will not use the returned value if it is nil and will check for other expression Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…egacy back to route (v3) Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
vindex-eval-engine
branch
from
18eed15
to
af0e7a0
Compare
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
force-pushed
the
vindex-eval-engine
branch
from
9a0a9dc
to
4f40d2a
Compare
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
commented
Dec 2, 2021
| if n.selectedVindex() != nil { | ||
| singleColumn = n.selected.foundVindex.(vindexes.SingleColumn) | ||
| values = n.selected.values | ||
| if len(n.selected.values) == 1 { |
There was a problem hiding this comment.
is this safe to do? @harshit-gangal
There was a problem hiding this comment.
the length is always going to be 1 for singleColumn Vindex. This check is not required.
Signed-off-by: Andres Taylor <andres@planetscale.com>
frouioui
reviewed
Dec 2, 2021
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
vindex-eval-engine
branch
from
9da8bfb
to
11878b4
Compare
frouioui
reviewed
Dec 2, 2021
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
changed the title
systay
commented
Dec 2, 2021
| case querypb.Type_TUPLE: | ||
| tuple := make([]EvalResult, 0, len(val.Values)) | ||
| for _, value := range val.Values { | ||
| single, err := evaluateByTypeSingle(value.Type, value.Value) |
There was a problem hiding this comment.
this should be evaluateByType, so we can support tuples inside of tuples
There was a problem hiding this comment.
that takes in bindvariable and val.Values range will give query.Value
systay
force-pushed
the
vindex-eval-engine
branch
from
5821afb
to
9da8bfb
Compare
harshit-gangal
force-pushed
the
vindex-eval-engine
branch
from
9da8bfb
to
57510b2
Compare
harshit-gangal
approved these changes
Dec 5, 2021
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
vindex-eval-engine
branch
from
57510b2
to
754a568
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces PlanValue with EvalEngineExpr to be used in route primitive. Created a separate logical plan and engine primitive of route for Gen4 planner.
Related Issue(s)
Checklist
Deployment Notes