Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use evalengine for Vindex lookups in route primitive #9291

Merged
merged 15 commits into from
Dec 5, 2021
Merged

Use evalengine for Vindex lookups in route primitive #9291

merged 15 commits into from
Dec 5, 2021

Commits on Dec 2, 2021

  1. refactor: split route into route and routeLegacy 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay @harshit-gangal
    systay authored and harshit-gangal committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    d2fabf4 View commit details
    Browse the repository at this point in the history

  2. feat: use evalengine.Expr instead of PlanValue on route 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay @harshit-gangal
    systay authored and harshit-gangal committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    e0add06 View commit details
    Browse the repository at this point in the history

  3. feat: update plan description to handle evalengine better 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay @harshit-gangal
    systay authored and harshit-gangal committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    e81ae1e View commit details
    Browse the repository at this point in the history

  4. refactor: remove unused field 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay @harshit-gangal
    systay authored and harshit-gangal committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    ed4cc4d View commit details
    Browse the repository at this point in the history

  5. feat: support ListArg in evalengine 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay @harshit-gangal
    systay authored and harshit-gangal committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    1926c6d View commit details
    Browse the repository at this point in the history

  6. feat: handle cases where columns are not allowed 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay @harshit-gangal
    systay authored and harshit-gangal committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    ce33106 View commit details
    Browse the repository at this point in the history

  7. feat: evalEngineExpr function to not return an error and plan operato… 

    …r will not use the returned value if it is nil and will check for other expression

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    e1598ef View commit details
    Browse the repository at this point in the history

  8. refactor: addressed comments and change route to routeGen4 and routeL… 

    …egacy back to route (v3)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    af0e7a0 View commit details
    Browse the repository at this point in the history

  9. refactor: remove routeLegacy and use engine.route for both v3 and gen4 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    4f40d2a View commit details
    Browse the repository at this point in the history

  10. refactor: rename function 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    957f7b3 View commit details
    Browse the repository at this point in the history

  11. test: re-insert accidentally removed test case 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    9a1a56a View commit details
    Browse the repository at this point in the history

  12. chore: year was wrong 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    9373533 View commit details
    Browse the repository at this point in the history

  13. feat: support tuple evaluation in evalEngine 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    11878b4 View commit details
    Browse the repository at this point in the history

  14. feat: error out for unsupported multi-column value vindex 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    5821afb View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2021

  1. test: add e2e test in gen4 for select with non-correlated subquery 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Dec 5, 2021
    Configuration menu
    Copy the full SHA
    754a568 View commit details
    Browse the repository at this point in the history