Initial commit to add the 'vstream * from' functionality back to vtgate #9392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit-nayak-ps
added
Component: VReplication
release notes
Type: Enhancement
rohit-nayak-ps
force-pushed
the
rn-vstream-from
branch
from
25434c6
to
b5bf33f
Compare
…ting for the refactoring on vtgate side. Also adds tests Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
force-pushed
the
rn-vstream-from
branch
from
b5bf33f
to
9d23927
Compare
rohit-nayak-ps
changed the title
rohit-nayak-ps
requested review from
frouioui,
shlomi-noach and
systay
as code owners
GuptaManan100
approved these changes
Dec 28, 2021
|
Currently, this uses a separate health check and picker logic, may be we can change this use the tabletgateway which also has the similar logic, may be it can make the logic simpler. If the refactor makes sense, this can be taken up in separate PR. |
harshit-gangal
approved these changes
Dec 30, 2021
3 tasks
3 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The experimental
vstream * fromvtgate query functionality (#6675) was temporarily removed in #9252 because it was crashing vtgate after a recent vtgate refactor.This PR changes the original functionality to be in line with the refactoring and also adds unit and e2e tests to alert us of such issues in the future.
As previous mentioned, the functionality is experimental and is intended to be provide a POC of what is possible. Once we have a firm requirement it will be enhanced.
Signed-off-by: Rohit Nayak rohit@planetscale.com
Related Issues
#6675
#9252
Checklist