Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reparent_journal: add backwards compatible alter statement #9439

Merged
merged 4 commits into from
Dec 31, 2021

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Dec 23, 2021

Description

Part 1 of renaming master_alias to primary_alias

Related Issue(s)

#8619

Checklist

  • Should this PR be backported?
  • Tests were added or are not required - we should verify this works as part of upgrade/downgrade testing
  • Documentation was added or is not required

Deployment Notes

@deepthi deepthi added Component: Cluster management release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) Type: Internal Cleanup labels Dec 23, 2021
@deepthi deepthi requested review from GuptaManan100 and removed request for doeg, shlomi-noach and ajm188 December 30, 2021 23:11
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
Copy link
Member Author

deepthi commented Dec 31, 2021

After fixing the panic, there is still a test failure

$ cd go/vt/vtgate
$ go test 
...
2021-12-31 09:29:38     INFO select.go:82] retrying plan after cnf: select * from INFORMATION_SCHEMA.foo
E1231 09:29:38.402715    2928 route.go:522] failed to route information_schema query to keyspace [vt_ks]
E1231 09:29:38.404243    2928 route.go:522] failed to route information_schema query to keyspace [vt_ks]
2021-12-31 09:29:38     INFO select.go:82] retrying plan after cnf: select * from INFORMATION_SCHEMA.`TABLES` where TABLE_SCHEMA = database()
E1231 09:29:38.579140    2928 vstream_manager.go:579] vstream for TestUnsharded/0 error: context canceled
E1231 09:29:38.579166    2928 vstream_manager.go:313] Error in vstream for keyspace:"TestUnsharded" shard:"0" gtid:"gtid01": context canceled
--- FAIL: TestStreamSQLSharded (0.01s)
    executor_stream_test.go:185: result: <nil>, want &{Fields:[name:"id" type:INT32 name:"value" type:VARCHAR] RowsAffected:0 InsertID:0 Rows:[[INT32(1) VARCHAR("foo")] [INT32(1) VARCHAR("foo")] [INT32(1) VARCHAR("foo")] [INT32(1) VARCHAR("foo")] [INT32(1) VARCHAR("foo")] [INT32(1) VARCHAR("foo")] [INT32(1) VARCHAR("foo")] [INT32(1) VARCHAR("foo")]] SessionStateChanges: StatusFlags:0}
W1231 09:29:38.591591    2928 executor.go:182] "select * from main1" exceeds warning threshold of max memory rows: 3

However, if I run just that one test, it passes

$ go test -run=TestStreamSQLSharded
ERROR: logging before flag.Parse: I1231 09:30:45.272020    2997 flags.go:185] vtgate buffer not enabled.
ERROR: logging before flag.Parse: I1231 09:30:45.272252    2997 discoverygateway.go:123] loading tablets for cells:
ERROR: logging before flag.Parse: I1231 09:30:45.272305    2997 gateway.go:103] Gateway waiting for serving tablets of types [] ...
ERROR: logging before flag.Parse: I1231 09:30:45.272312    2997 gateway.go:111] Waiting for tablets completed
ERROR: logging before flag.Parse: I1231 09:30:45.272329    2997 vtgate.go:106] Transaction mode: 'MULTI'
ERROR: logging before flag.Parse: I1231 09:30:45.272824    2997 vschema_manager.go:102] Received vschema update
ERROR: logging before flag.Parse: I1231 09:30:45.273192    2997 streamlog.go:158] Streaming logs from VTGate at /debug/querylog.
PASS
ok  	vitess.io/vitess/go/vt/vtgate	0.290s

Possibly there is some interaction between different tests that is causing this to fail only when the full suite is run.

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
Copy link
Member Author

deepthi commented Dec 31, 2021

Looks like this test broke in #9392, but moving the new test to the end of the file fixes it. There's an underlying problem with test dependencies but we can work around it with this change.

Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cluster management release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) Type: Internal Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants