-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reparent_journal: add backwards compatible alter statement #9439
Conversation
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
3f3bc36
to
3975100
Compare
After fixing the panic, there is still a test failure
However, if I run just that one test, it passes
Possibly there is some interaction between different tests that is causing this to fail only when the full suite is run. |
Signed-off-by: deepthi <deepthi@planetscale.com>
Looks like this test broke in #9392, but moving the new test to the end of the file fixes it. There's an underlying problem with test dependencies but we can work around it with this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Part 1 of renaming master_alias to primary_alias
Related Issue(s)
#8619
Checklist
Deployment Notes