Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtctl: delete deprecated flag #9406

Merged
merged 1 commit into from
Dec 21, 2021
Merged

vtctl: delete deprecated flag #9406

merged 1 commit into from
Dec 21, 2021

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Dec 17, 2021 •
edited
Loading

Description

Missed one in #9179
This is a breaking change.

Related Issue(s)

#8838

Checklist

Deployment Notes

Anyone using the old flag should change their scripts to use the new flag.

@deepthi
vtctl: delete deprecated flag
aba6094 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi mentioned this pull request Dec 17, 2021
Merged
rohit-nayak-ps
rohit-nayak-ps approved these changes Dec 18, 2021
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deepthi deepthi merged commit a2b0225 into vitessio:main Dec 21, 2021
@deepthi deepthi deleted the ds-delete-blacklist branch December 21, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@ajm188 ajm188 Awaiting requested review from ajm188

@doeg doeg Awaiting requested review from doeg

Assignees
No one assigned
Labels
Breaking change Component: vtctl Type: Internal Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepthi @rohit-nayak-ps