Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): fix toHaveClass typing #7383

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jan 30, 2025

Description

I think there's some dts specific magic going on as to why standard overload is not working. I couldn't figure that out, so I went for a different way and made a union on argument types, which should achieves the same for user's type safety.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f6bef70
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/679ad5a3145c970008d1d33a
😎 Deploy Preview https://deploy-preview-7383--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jan 30, 2025

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7383

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7383

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7383

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7383

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7383

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7383

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7383

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7383

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7383

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7383

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7383

vite-node

npm i https://pkg.pr.new/vite-node@7383

vitest

npm i https://pkg.pr.new/vitest@7383

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7383

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7383

commit: f6bef70

@hi-ogawa hi-ogawa marked this pull request as ready for review January 30, 2025 01:34
@sheremet-va sheremet-va merged commit 7ef238c into vitest-dev:main Feb 4, 2025
15 checks passed
@hi-ogawa hi-ogawa deleted the fix-toHaveClass-exact branch February 4, 2025 23:21
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 18, 2025
##### [v3.0.6](https://github.com/vitest-dev/vitest/releases/tag/v3.0.6)

#####    🐞 Bug Fixes

-   Fix `getMockedSystemTime` for `useFakeTimer`  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7405 [<samp>(03912)</samp>](vitest-dev/vitest@03912b43)
-   Compat for jest-image-snapshot  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7390 [<samp>(9542b)</samp>](vitest-dev/vitest@9542b699)
-   Ensure project names are readable in dark terminals  -  by [@rgrove](https://github.com/rgrove) in vitest-dev/vitest#7371 [<samp>(bb94c)</samp>](vitest-dev/vitest@bb94c19f)
-   Exclude `queueMicrotask` from default fake timers to not break node fetch  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7505 [<samp>(167a9)</samp>](vitest-dev/vitest@167a98d7)
-   **browser**:
    -   Fix mocking modules out of root  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7415 [<samp>(d3acb)</samp>](vitest-dev/vitest@d3acbd8b)
    -   Fix `toHaveClass` typing  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7383 [<samp>(7ef23)</samp>](vitest-dev/vitest@7ef238c0)
    -   Relax locator selectors methods  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7422 [<samp>(1b8c5)</samp>](vitest-dev/vitest@1b8c5c9e)
    -   Resolve thread count from `maxWorkers`  -  by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7483 [<samp>(adbb2)</samp>](vitest-dev/vitest@adbb25ab)
    -   Cleanup timeout on resolve and give more information in the error  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7487 [<samp>(5a45a)</samp>](vitest-dev/vitest@5a45a7ca)
-   **coverage**:
    -   `vite-node` to pass correct execution wrapper offset  -  by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7417 [<samp>(1f2e5)</samp>](vitest-dev/vitest@1f2e5552)
    -   Preserve moduleExecutionInfo in non-isolated runs  -  by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7486 [<samp>(f31a0)</samp>](vitest-dev/vitest@f31a07bb)
-   **deps**:
    -   Update all non-major dependencies  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7363 [<samp>(e348b)</samp>](vitest-dev/vitest@e348bd4c)
    -   Update all non-major dependencies  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7507 [<samp>(6cc40)</samp>](vitest-dev/vitest@6cc408d6)
-   **init**:
    -   Invalid browser config  -  by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7475 [<samp>(8fe64)</samp>](vitest-dev/vitest@8fe641b4)
-   **reporters**:
    -   Render tasks in tree when in TTY  -  by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7503 [<samp>(027ce)</samp>](vitest-dev/vitest@027ce9bb)
-   **vite-node**:
    -   Remove fake first line mapping on Vite 6  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7124 [<samp>(b9973)</samp>](vitest-dev/vitest@b997355b)
-   **watch**:
    -   Properly remove cache after removing existing test files  -  by [@soc221b](https://github.com/soc221b) in vitest-dev/vitest#7399 [<samp>(01a59)</samp>](vitest-dev/vitest@01a59721)
-   **workspace**:
    -   Forward `inspect` related cli options  -  by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7373 [<samp>(ed15b)</samp>](vitest-dev/vitest@ed15b5b3)

#####     [View changes on GitHub](vitest-dev/vitest@v3.0.5...v3.0.6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toHaveClass has incorrect types when { exact: true } is used
3 participants