Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude queueMicrotask from default fake timers to not break node fetch #7505

Merged
merged 5 commits into from
Feb 18, 2025
Merged

fix: exclude queueMicrotask from default fake timers to not break node fetch #7505

merged 5 commits into from
Feb 18, 2025

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 17, 2025 •
edited
Loading

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify Netlify
Copy link

netlify bot commented Feb 17, 2025 •
edited
Loading

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bc2e44e
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67b2f3805905eb000836392e
😎 Deploy Preview https://deploy-preview-7505--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa changed the title fix: exclude queueMicrotask from default fake timers for node fetch fix: exclude queueMicrotask from default fake timers to not break node fetch Feb 17, 2025
@hi-ogawa hi-ogawa marked this pull request as ready for review February 17, 2025 02:34
AriPerkkio
AriPerkkio requested changes Feb 17, 2025
View reviewed changes
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mention this in docs:

vitest/docs/api/vi.md

Lines 820 to 823 in 7bfa70c

::: tip
`vi.useFakeTimers()` does not automatically mock `process.nextTick`.
But you can enable it by specifying the option in `toFake` argument: `vi.useFakeTimers({ toFake: ['nextTick'] })`.
:::

@AriPerkkio AriPerkkio merged commit 167a98d into vitest-dev:main Feb 18, 2025
12 of 13 checks passed
@hi-ogawa hi-ogawa deleted the fix-no-fakeTimers-queueMicrotask branch February 18, 2025 09:06
renovate bot added a commit to mmkal/expect-type that referenced this pull request Feb 18, 2025
@renovate
chore(deps): update vitest monorepo to v3.0.6
a09d5ff 
##### [v3.0.6](https://github.com/vitest-dev/vitest/releases/tag/v3.0.6)

#####    🐞 Bug Fixes

-   Fix `getMockedSystemTime` for `useFakeTimer`  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7405 [<samp>(03912)</samp>](vitest-dev/vitest@03912b43)
-   Compat for jest-image-snapshot  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7390 [<samp>(9542b)</samp>](vitest-dev/vitest@9542b699)
-   Ensure project names are readable in dark terminals  -  by [@rgrove](https://github.com/rgrove) in vitest-dev/vitest#7371 [<samp>(bb94c)</samp>](vitest-dev/vitest@bb94c19f)
-   Exclude `queueMicrotask` from default fake timers to not break node fetch  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7505 [<samp>(167a9)</samp>](vitest-dev/vitest@167a98d7)
-   **browser**:
    -   Fix mocking modules out of root  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7415 [<samp>(d3acb)</samp>](vitest-dev/vitest@d3acbd8b)
    -   Fix `toHaveClass` typing  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7383 [<samp>(7ef23)</samp>](vitest-dev/vitest@7ef238c0)
    -   Relax locator selectors methods  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7422 [<samp>(1b8c5)</samp>](vitest-dev/vitest@1b8c5c9e)
    -   Resolve thread count from `maxWorkers`  -  by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7483 [<samp>(adbb2)</samp>](vitest-dev/vitest@adbb25ab)
    -   Cleanup timeout on resolve and give more information in the error  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7487 [<samp>(5a45a)</samp>](vitest-dev/vitest@5a45a7ca)
-   **coverage**:
    -   `vite-node` to pass correct execution wrapper offset  -  by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7417 [<samp>(1f2e5)</samp>](vitest-dev/vitest@1f2e5552)
    -   Preserve moduleExecutionInfo in non-isolated runs  -  by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7486 [<samp>(f31a0)</samp>](vitest-dev/vitest@f31a07bb)
-   **deps**:
    -   Update all non-major dependencies  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7363 [<samp>(e348b)</samp>](vitest-dev/vitest@e348bd4c)
    -   Update all non-major dependencies  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7507 [<samp>(6cc40)</samp>](vitest-dev/vitest@6cc408d6)
-   **init**:
    -   Invalid browser config  -  by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7475 [<samp>(8fe64)</samp>](vitest-dev/vitest@8fe641b4)
-   **reporters**:
    -   Render tasks in tree when in TTY  -  by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7503 [<samp>(027ce)</samp>](vitest-dev/vitest@027ce9bb)
-   **vite-node**:
    -   Remove fake first line mapping on Vite 6  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7124 [<samp>(b9973)</samp>](vitest-dev/vitest@b997355b)
-   **watch**:
    -   Properly remove cache after removing existing test files  -  by [@soc221b](https://github.com/soc221b) in vitest-dev/vitest#7399 [<samp>(01a59)</samp>](vitest-dev/vitest@01a59721)
-   **workspace**:
    -   Forward `inspect` related cli options  -  by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7373 [<samp>(ed15b)</samp>](vitest-dev/vitest@ed15b5b3)

#####     [View changes on GitHub](vitest-dev/vitest@v3.0.5...v3.0.6)
@renovate renovate bot mentioned this pull request Feb 25, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AriPerkkio AriPerkkio AriPerkkio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vitest 3 - Freeze/out of memory error with useFakeTimers after upgrade
2 participants
@hi-ogawa @AriPerkkio