[Nvidia] [mlnx-fw-upgrade] Always Redirect RunCmd stderr to syslog #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
vivekrnv
changed the title
vivekrnv
pushed a commit
that referenced
this pull request
Oct 13, 2023
…e latest HEAD automatically (sonic-net#15016) src/wpasupplicant/sonic-wpa-supplicant * a24412c25 - (HEAD -> 202205, origin/master, origin/HEAD, origin/202211, origin/202205, master) [mka]: Fix unexpected cleanup (#73) (8 days ago) [Ze Gan] * 26d1da0bc - [mka]: Fix re-establishment by reset MI (#72) (8 days ago) [Ze Gan] * f07e0a097 - [azp]: Update build pipeline to build for Bullseye (#70) (4 weeks ago) [Ze Gan] * 2c69e2cda - Use github code scanning instead of LGTM (#69) (6 months ago) [Liu Shilong] |\ | * 23abb04e5 - fix (6 months ago) [shilongliu] | * f34d68fe6 - libdbus-1-dev (6 months ago) [shilongliu] | * dc2dd881e - add dbus (6 months ago) [shilongliu] | * 5de037661 - use swsscommon packages (6 months ago) [shilongliu] | * 32c5a2729 - Use github code scanning instead of LGTM (6 months ago) [shilongliu] |/ * aa731b96f - [azp]: Install libyang in azure pipeline (#68) (8 months ago) [Hua Liu] * 71b635d74 - Revert "[Azp]: Upgrade Azp to bullseye (#49)" (#66) (9 months ago) [Ze Gan] * 7aa4e6fa4 - Adding Microsoft SECURITY.MD (#58) (9 months ago) [microsoft-github-policy-service[bot]]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
When mlxfwquery fails during fw-upgrade script, no error is logged on why it is failed
How I did it
RunCmd is used with Query and list-content and both of which redirect any useful output to the file specified by the -o arg.
When not run in verbose mode, the stderr is redirected to /dev/null and thus update to always redirect any stderr to syslog
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)