Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rsyslogd conf should be updated after every reload/reboot #72

Closed
wants to merge 4 commits into from

Conversation

vivekrnv
Copy link
Owner

@vivekrnv vivekrnv commented Aug 15, 2023

Why I did it

Partial fix to the issue https://github.com/sonic-net/sonic-buildimage/issues/15152.

rsyslogd process inside the container is running but it is not writing any log to the host (not even the init log). It is not recoverable even after a config reload or reboot.

The /etc/rsyslog.conf under each container is written at the beginning of docker start once after ONIE and later the same file is re-used even after reboot. It is likely that something would have happened while creating a conf file possibly with TARGET_IP and the problem would've persisted.

Thus updating the script to make the problem recoverable with config-reload & reboot and more dumps to techsupport to understand the problem.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Made sure the /etc/rsyslog.conf is generated for every container and the logs are seen for every container

  1. Check which disallows writing the rsyslog.conf to the container the second time is removed. This should make the problem recoverable
  2. Removed the sonic-cfggen to generate the template. RateLimitBurst and RateLimitInterval are anyway updated by the containercfgd and so they don't have to be updated here.

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@vivekrnv vivekrnv changed the title Rsyslogd conf should be updated after every reload/reboot and not use sonic-cfggen Rsyslogd conf should be updated after every reload/reboot Aug 15, 2023
Copy link

@Junchao-Mellanox Junchao-Mellanox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please verify the change does not cause fastboot downtime degradation?

@vivekrnv vivekrnv marked this pull request as draft September 30, 2023 00:43
vivekrnv pushed a commit that referenced this pull request Oct 13, 2023
…e latest HEAD automatically (sonic-net#15016)

src/wpasupplicant/sonic-wpa-supplicant

* a24412c25 - (HEAD -> 202205, origin/master, origin/HEAD, origin/202211, origin/202205, master) [mka]: Fix unexpected cleanup (#73) (8 days ago) [Ze Gan]
* 26d1da0bc - [mka]: Fix re-establishment by reset MI (#72) (8 days ago) [Ze Gan]
* f07e0a097 - [azp]: Update build pipeline to build for Bullseye (#70) (4 weeks ago) [Ze Gan]
*   2c69e2cda - Use github code scanning instead of LGTM (#69) (6 months ago) [Liu Shilong]
|\  
| * 23abb04e5 - fix (6 months ago) [shilongliu]
| * f34d68fe6 - libdbus-1-dev (6 months ago) [shilongliu]
| * dc2dd881e - add dbus (6 months ago) [shilongliu]
| * 5de037661 - use swsscommon packages (6 months ago) [shilongliu]
| * 32c5a2729 - Use github code scanning instead of LGTM (6 months ago) [shilongliu]
|/  
* aa731b96f - [azp]: Install libyang in azure pipeline (#68) (8 months ago) [Hua Liu]
* 71b635d74 - Revert "[Azp]: Upgrade Azp to bullseye (#49)" (#66) (9 months ago) [Ze Gan]
* 7aa4e6fa4 - Adding Microsoft SECURITY.MD (#58) (9 months ago) [microsoft-github-policy-service[bot]]
@vivekrnv vivekrnv closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants