Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should prevent PgUp, PgDn keypress events to pass to parent elements. #43

Closed
veghdev opened this issue Dec 2, 2022 · 1 comment · Fixed by #47
Closed

should prevent PgUp, PgDn keypress events to pass to parent elements. #43

veghdev opened this issue Dec 2, 2022 · 1 comment · Fixed by #47
Assignees
@dovicsin

Comments

@veghdev
Copy link
Member

veghdev commented Dec 2, 2022 •
edited by simzer
Loading

environment issues: Colab, Deepnote, PgUp, PgDn buttons scroll the notebook even after the chart is clicked

PgUp, PgDn buttons scroll the notebook even after the chart is clicked (separated from the issues vizzuhq/ipyvizzu-story#2 vizzuhq/ipyvizzu-story#3)
@veghdev veghdev added the bug Something isn't working label Dec 2, 2022
This was referenced Dec 2, 2022
Closed
Closed
@schaumb schaumb transferred this issue from vizzuhq/ipyvizzu-story Jul 3, 2023
@schaumb schaumb removed the bug Something isn't working label Jul 3, 2023
@simzer simzer changed the title environment issues: Colab, Deepnote, PgUp, PgDn buttons scroll the notebook even after the chart is clicked Should prevent PgUp, PgDn keypress events to pass to parent elements. Jul 3, 2023
@veghdev veghdev changed the title Should prevent PgUp, PgDn keypress events to pass to parent elements. should prevent PgUp, PgDn keypress events to pass to parent elements. Jul 3, 2023
@dovicsin
Copy link
Contributor

it is also true for the home and end buttons

dovicsin added a commit to dovicsin/vizzu-story-js that referenced this issue Aug 16, 2023
@dovicsin
catch key event if controller focus is active, fix vizzuhq#43
095bfd9
@dovicsin dovicsin self-assigned this Aug 16, 2023
@veghdev veghdev mentioned this issue Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dovicsin dovicsin

Labels
None yet
Projects
No open projects
ipyvizzu-story: environment issues
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed: catch key event if controller focus is active dovicsin/vizzu-story-js
3 participants
@schaumb @veghdev @dovicsin