Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds language selector to preferences #680

Merged
merged 4 commits into from
Feb 17, 2021
Merged

Conversation

bkmeneguello
Copy link
Contributor

No description provided.

@vkbo vkbo added this to the Release 1.3 Beta 1 milestone Feb 17, 2021
@vkbo
Copy link
Owner

vkbo commented Feb 17, 2021

Thanks!

The listLanguages function was missing a few checks, and assumed the wrong default language. It's British English, not American English. I rewrote it to a simpler syntax where I could add those checks.

Also, remember to add docstrings to functions and please don't use the hanging indentation scheme. It breaks indentation guides for those who use them in editors (I do) and is a lot harder to read.

@vkbo vkbo merged commit 770c746 into vkbo:dev Feb 17, 2021
@vkbo vkbo linked an issue Feb 17, 2021 that may be closed by this pull request
@bkmeneguello bkmeneguello deleted the Languages-GUI branch October 26, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations of novelWriter
2 participants