Build and push CPU image to ecr #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huy Do <huydhn@gmail.com>
Collaborator
|
Do we have a test plan for this? |
Collaborator
Author
|
Let me ask @khluu on how to test CI change here. IIRC, one could create a mock PR on vLLM to test this |
seemethere
approved these changes
Jul 2, 2025
Collaborator
seemethere
left a comment
seemethere
left a comment
There was a problem hiding this comment.
LGTM, would like to see a test job
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
Collaborator
Author
|
@seemethere Testing is progress https://buildkite.com/vllm/ci/builds/23120#0197cc69-196e-4fcb-8475-4dde0e1a5531 Update: It's done https://buildkite.com/vllm/ci/builds/23120#0197cc69-196e-4fcb-8475-4dde0e1a5531/118-7774 and the image pushed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support CPU benchmark from vllm-project/vllm#18444, we would need to push the Docker image to ECR, which can then be used either in benchmark CI job or locally.
cc @louie-tsai @seemethere @khluu