Skip to content

Build and push CPU image to ecr #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 2, 2025
Merged

Build and push CPU image to ecr #118

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5c2332
Build and push CPU image to ecr
huydhn Jul 1, 2025
4b20460
Merge branch 'main' into push-cpu-docker-image-ecr
huydhn Jul 1, 2025
7179479
Always build CPU docker image in trunk
huydhn Jul 2, 2025
e2a61a5
Use vllm-test target
huydhn Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion buildkite/test-template-ci.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
{% set docker_image = "public.ecr.aws/q9t5s3a7/vllm-ci-test-repo:$BUILDKITE_COMMIT" %}
{% set docker_image_torch_nightly = "public.ecr.aws/q9t5s3a7/vllm-ci-test-repo:$BUILDKITE_COMMIT-torch-nightly" %}
{% set docker_image_cu118 = "public.ecr.aws/q9t5s3a7/vllm-ci-test-repo:$BUILDKITE_COMMIT-cu118" %}
{% set docker_image_cpu = "public.ecr.aws/q9t5s3a7/vllm-ci-test-repo:$BUILDKITE_COMMIT-cpu" %}
{% if branch == "main" %}
{% set docker_image = "public.ecr.aws/q9t5s3a7/vllm-ci-postmerge-repo:$BUILDKITE_COMMIT" %}
{% set docker_image_latest = "public.ecr.aws/q9t5s3a7/vllm-ci-postmerge-repo:latest" %}
{% set docker_image_torch_nightly = "public.ecr.aws/q9t5s3a7/vllm-ci-postmerge-repo:$BUILDKITE_COMMIT-torch-nightly" %}
{% set docker_image_cu118 = "public.ecr.aws/q9t5s3a7/vllm-ci-postmerge-repo:$BUILDKITE_COMMIT-cu118" %}
{% set docker_image_cpu = "public.ecr.aws/q9t5s3a7/vllm-ci-postmerge-repo:$BUILDKITE_COMMIT-cpu" %}
{% endif %}
{% set docker_image_amd = "rocm/vllm-ci:$BUILDKITE_COMMIT" %}
{% set default_working_dir = "/vllm-workspace/tests" %}
Expand Down Expand Up @@ -182,6 +184,36 @@ steps:
- exit_status: -10 # Agent was lost
limit: 2

- label: ":docker: build image CPU"
key: image-build-cpu
depends_on: ~
agents:
{% if branch == "main" %}
queue: cpu_queue_postmerge
{% else %}
queue: cpu_queue_premerge
{% endif %}
commands:
- "aws ecr-public get-login-password --region us-east-1 | docker login --username AWS --password-stdin public.ecr.aws/q9t5s3a7"
- |
#!/bin/bash
if [[ -z $(docker manifest inspect {{ docker_image_cpu }}) ]]; then
echo "Image not found, proceeding with build..."
else
echo "Image found"
exit 0
fi
- "docker build --file docker/Dockerfile.cpu --build-arg max_jobs=16 --build-arg buildkite_commit=$BUILDKITE_COMMIT --tag {{ docker_image_cpu }} --target vllm-test --progress plain ."
- "docker push {{ docker_image_cpu }}"
env:
DOCKER_BUILDKIT: "1"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
- exit_status: -10 # Agent was lost
limit: 2

{% for step in steps %}
{% if step.fast_check_only != true %}

Expand Down Expand Up @@ -285,7 +317,7 @@ steps:
{% else %}
{% set ns.blocked = 0 %}
{% endif %}

{% if ns.blocked == 1 or (step.optional and nightly != "1") %}
- block: "Run Torch Nightly {{ step.label }}"
depends_on: image-build-torch-nightly
Expand Down