[Misc] Refactor additional_config #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
wangxiyuan
force-pushed
the
refactor_additional_config
branch
9 times, most recently
from
ffccd82 to
ef2a9c4
Compare
wangxiyuan
commented
Jun 3, 2025
76 tasks
wangxiyuan
force-pushed
the
refactor_additional_config
branch
from
ef2a9c4 to
20454d2
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
wangxiyuan
force-pushed
the
refactor_additional_config
branch
from
20454d2 to
8bd3363
Compare
wangxiyuan
force-pushed
the
refactor_additional_config
branch
from
8bd3363 to
85251ec
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
wangxiyuan
force-pushed
the
refactor_additional_config
branch
2 times, most recently
from
760de10 to
4e5f81c
Compare
wangxiyuan
force-pushed
the
refactor_additional_config
branch
from
4e5f81c to
7a2d5d5
Compare
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
wangxiyuan
force-pushed
the
refactor_additional_config
branch
from
7a2d5d5 to
70757c0
Compare
Yikun
approved these changes
Jun 5, 2025
ApsarasX
approved these changes
Jun 5, 2025
|
I'll merge this in quick to unblock other PRs. Feel free to fix any issue later. Thanks. |
venus-taibai
pushed a commit
to venus-taibai/vllm-ascend
that referenced
this pull request
Jun 18, 2025
…llm-project#1092) Merge branch wengang/cherry-pick-1029-1092 of git@code.alipay.com:Theta/vllm-ascend.git into dev-v0.9.0604 https://code.alipay.com/Theta/vllm-ascend/pull_requests/108 Reviewed-by: 子宏 <tanzhiqiang.tzq@antgroup.com> * [Misc] Refactor additional_config (vllm-project#1029) * [BugFix] Fix ascend config check (vllm-project#1092) * [Misc] Update benchmark scripts
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Oct 16, 2025
More and more config options are added to additional_config. This PR provide a new AscendConfig to manage these config options by an easier way to make code cleaner and readable. This PR also added the `additional_config` doc for users. Added the test_ascend_config.py to make sure the new AscendConfig works as expect. TODO: Add e2e test with torchair and deepseek once the CI resource is available. Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
More and more config options are added to additional_config. This PR provide a new AscendConfig to manage these config options by an easier way to make code cleaner and readable. This PR also added the `additional_config` doc for users. Added the test_ascend_config.py to make sure the new AscendConfig works as expect. TODO: Add e2e test with torchair and deepseek once the CI resource is available. Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More and more config options are added to additional_config. This PR provide a new AscendConfig to manage these config options by an easier way to make code cleaner and readable.
This PR also added the
additional_configdoc for users.Added the test_ascend_config.py to make sure the new AscendConfig works as expect.
TODO: Add e2e test with torchair and deepseek once the CI resource is available.