-
Notifications
You must be signed in to change notification settings - Fork 536
feat: support compile torchair graph while warming up #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a49f965 to
99be815
Compare
71634df to
44b77b9
Compare
5caa186 to
42544de
Compare
| torch._logging.set_logs(recompiles=True) | ||
| self.torchair_graph_batch_sizes = additional_config.get( | ||
| "torchair_graph_batch_sizes", []) | ||
| if not isinstance(self.torchair_graph_batch_sizes, list): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have enable_graph_mode to controller torchair, here named torchair_graph_batch_sizes, w'd better to use the same prefix. How about use torchair_graph for all case? cc @zzzzwwjj
|
I added a new ascendconfig to deal with all additional_config #1029 . The comment I added before can be addressed later. Please fix the merge conflict, then the PR is ready to go IMO. |
|
test_scheduler.py should be updated as well. for example |
41e28c9 to
54f3a05
Compare
I noticed you are trying to fix scheduler UT via frequetly changes, this might the effective way to reproduce and run test locally |
5f20f3c to
53679a8
Compare
Signed-off-by: boying <897013703@qq.com>
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com>
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com>
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com> Signed-off-by: wangxiaoxin (A) <w00664509@china.huawei.com>
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com>
### What this PR does / why we need it? feat: support compile torchair graph while warming up Signed-off-by: boying <897013703@qq.com>
What this PR does / why we need it?
feat: support compile torchair graph while warming up
Does this PR introduce any user-facing change?
How was this patch tested?