Skip to content

Conversation

@Yikun
Copy link
Collaborator

@Yikun Yikun commented Jul 1, 2025

What this PR does / why we need it?

Use Base test and cleanup all manaul patch code

  • Cleanup EPLB config to avoid tmp test file
  • Use BaseTest with global cache
  • Add license
  • Add a doc to setup unit test in local env

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI passed

@Yikun Yikun force-pushed the test-ut branch 2 times, most recently from 5f95402 to f936e09 Compare July 1, 2025 22:07
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 1, 2025
@Yikun Yikun force-pushed the test-ut branch 2 times, most recently from 72fa1a9 to 65e15d1 Compare July 2, 2025 05:09
@Yikun Yikun changed the title Use Base test and cleanup all manaul patch code Add unit test local cpu guide and enable base testcase Jul 2, 2025
@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.34%. Comparing base (c30ddb8) to head (68e2724).
⚠️ Report is 613 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1566       +/-   ##
===========================================
+ Coverage   27.39%   52.34%   +24.95%     
===========================================
  Files          56       78       +22     
  Lines        6191     9628     +3437     
===========================================
+ Hits         1696     5040     +3344     
- Misses       4495     4588       +93     
Flag Coverage Δ
unittests 52.34% <100.00%> (+24.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yikun Yikun force-pushed the test-ut branch 2 times, most recently from c09a6a6 to 5640dd7 Compare July 2, 2025 10:35
@github-actions
Copy link

github-actions bot commented Jul 3, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun Yikun marked this pull request as ready for review July 6, 2025 02:39
@Yikun Yikun merged commit 0c1d239 into vllm-project:main Jul 6, 2025
14 checks passed
wangxiyuan pushed a commit that referenced this pull request Jul 22, 2025
### What this PR does / why we need it?
Use base test to avoid patch everwhere.

Followup here: #1566

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
ut ci passed

- vLLM version: v0.9.2
- vLLM main:
vllm-project/vllm@8d0a01a

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Sep 26, 2025
### What this PR does / why we need it?
Use base test to avoid patch everwhere.

Followup here: vllm-project#1566

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
ut ci passed

- vLLM version: v0.9.2
- vLLM main:
vllm-project/vllm@8d0a01a

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Oct 16, 2025
…1566)

### What this PR does / why we need it?
Use Base test and cleanup all manaul patch code
- Cleanup EPLB config to avoid tmp test file
- Use BaseTest with global cache
- Add license
- Add a doc to setup unit test in local env 

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
…1566)

### What this PR does / why we need it?
Use Base test and cleanup all manaul patch code
- Cleanup EPLB config to avoid tmp test file
- Use BaseTest with global cache
- Add license
- Add a doc to setup unit test in local env 

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
### What this PR does / why we need it?
Use base test to avoid patch everwhere.

Followup here: vllm-project#1566

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
ut ci passed

- vLLM version: v0.9.2
- vLLM main:
vllm-project/vllm@8d0a01a

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation module:tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants