[FOLLOWUP] Use base test to avoid patch everwhere #1634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1634 +/- ##
==========================================
- Coverage 60.25% 60.24% -0.01%
==========================================
Files 73 73
Lines 8006 8004 -2
==========================================
- Hits 4824 4822 -2
Misses 3182 3182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wangxiyuan
approved these changes
Jul 7, 2025
wangxiyuan
reviewed
Jul 7, 2025
| class TestSimpleBuffer(TestBase): | ||
|
|
||
| def setUp(self): | ||
| self.pipe = MockSimplePipe() |
Collaborator
There was a problem hiding this comment.
I'm not sure if the supper.setup is needed here.
Collaborator
Author
There was a problem hiding this comment.
will confirm soon, I think yes
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
wangxiyuan
approved these changes
Jul 22, 2025
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Sep 26, 2025
### What this PR does / why we need it? Use base test to avoid patch everwhere. Followup here: vllm-project#1566 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ut ci passed - vLLM version: v0.9.2 - vLLM main: vllm-project/vllm@8d0a01a Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
### What this PR does / why we need it? Use base test to avoid patch everwhere. Followup here: vllm-project#1566 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ut ci passed - vLLM version: v0.9.2 - vLLM main: vllm-project/vllm@8d0a01a Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Use base test to avoid patch everwhere.
Followup here: #1566
Does this PR introduce any user-facing change?
No
How was this patch tested?
ut ci passed