Record vLLM commit in PR description #1623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Yikun
force-pushed
the
pr_update
branch
26 times, most recently
from
11b6b03 to
b3461fb
Compare
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1623 +/- ##
===========================================
+ Coverage 27.39% 52.36% +24.96%
===========================================
Files 56 78 +22
Lines 6191 9631 +3440
===========================================
+ Hits 1696 5043 +3347
- Misses 4495 4588 +93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wangxiyuan
approved these changes
Jul 7, 2025
vllm-ascend-ci
added
ready-for-test
This was referenced Jul 8, 2025
Yikun
added a commit
that referenced
this pull request
Jul 10, 2025
### What this PR does / why we need it? Use ci_vllm_version when recording vllm commit Followup on #1623 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Test mannually. $ python3 docs/source/conf.py | jq .ci_vllm_version | tr -d '"' v0.9.2 - Test on my local repo: Yikun#35 - vLLM version: v0.9.1 - vLLM main: vllm-project/vllm@49e8c7e Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Oct 16, 2025
### What this PR does / why we need it? This patch enables the vllm commits recording and also cleanup unused commit msg note in PR. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - CI passed - Test on Yikun#33 and vllm commit refreshed as expected. Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Oct 16, 2025
### What this PR does / why we need it? Use ci_vllm_version when recording vllm commit Followup on vllm-project#1623 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Test mannually. $ python3 docs/source/conf.py | jq .ci_vllm_version | tr -d '"' v0.9.2 - Test on my local repo: Yikun#35 - vLLM version: v0.9.1 - vLLM main: vllm-project/vllm@49e8c7e Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
### What this PR does / why we need it? This patch enables the vllm commits recording and also cleanup unused commit msg note in PR. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - CI passed - Test on Yikun#33 and vllm commit refreshed as expected. Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
### What this PR does / why we need it? Use ci_vllm_version when recording vllm commit Followup on vllm-project#1623 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Test mannually. $ python3 docs/source/conf.py | jq .ci_vllm_version | tr -d '"' v0.9.2 - Test on my local repo: Yikun#35 - vLLM version: v0.9.1 - vLLM main: vllm-project/vllm@49e8c7e Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This patch enables the vllm commits recording and also cleanup unused commit msg note in PR.
Does this PR introduce any user-facing change?
No
How was this patch tested?