Skip to content

Conversation

@Yikun
Copy link
Collaborator

@Yikun Yikun commented Jul 9, 2025

What this PR does / why we need it?

Use ci_vllm_version when recording vllm commit

Followup on #1623

Does this PR introduce any user-facing change?

No

How was this patch tested?

@Yikun Yikun marked this pull request as ready for review July 9, 2025 06:47
@Yikun
Copy link
Collaborator Author

Yikun commented Jul 9, 2025

Wait for test / lint (3.10) (pull_request) passed

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 9, 2025
@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.48%. Comparing base (c30ddb8) to head (1829e39).
⚠️ Report is 613 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1689       +/-   ##
===========================================
+ Coverage   27.39%   54.48%   +27.09%     
===========================================
  Files          56       79       +23     
  Lines        6191     9925     +3734     
===========================================
+ Hits         1696     5408     +3712     
- Misses       4495     4517       +22     
Flag Coverage Δ
unittests 54.48% <ø> (+27.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yikun Yikun force-pushed the ci_vllm_version branch 2 times, most recently from af5cdf2 to fcc5d36 Compare July 10, 2025 01:43
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun Yikun force-pushed the ci_vllm_version branch from fcc5d36 to 1829e39 Compare July 10, 2025 02:51
@Yikun
Copy link
Collaborator Author

Yikun commented Jul 10, 2025

Test on my local repo: Yikun#36

@Yikun Yikun merged commit 997f156 into vllm-project:main Jul 10, 2025
10 of 12 checks passed
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Oct 16, 2025
### What this PR does / why we need it?
Use ci_vllm_version when recording vllm commit

Followup on vllm-project#1623

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
- Test mannually.
$ python3 docs/source/conf.py | jq .ci_vllm_version | tr -d '"'
v0.9.2
- Test on my local repo: Yikun#35

- vLLM version: v0.9.1
- vLLM main:
vllm-project/vllm@49e8c7e

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
### What this PR does / why we need it?
Use ci_vllm_version when recording vllm commit

Followup on vllm-project#1623

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
- Test mannually.
$ python3 docs/source/conf.py | jq .ci_vllm_version | tr -d '"'
v0.9.2
- Test on my local repo: Yikun#35

- vLLM version: v0.9.1
- vLLM main:
vllm-project/vllm@49e8c7e

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants