[attn] fix device of tensors in attention #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Fix device of tensors created in
AscendAttentionBackendImpl
.While specifying device to cards except card-0, there'll cause an device conflict because the tensors (such as
attn_mask
) will be put on card-0 by default.This pr creates these tensors on the correct card corresponding to the input.
Does this PR introduce any user-facing change?
User could specify device with local rank by this pr, and a modify on vLLM is also needed, will related to this pr when created.
How was this patch tested?
This is tested by the following code locally. Will add a test case when the modify in vLLM is also completed.
Results