-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[executor] init local_rank
as device index
#13027
Conversation
Signed-off-by: Mengqing Cao <cmq0113@163.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
(cc @youkaichao in case you see any gotchas)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the device
is not really intended to be a way to specify the device index, but i have no objections to it.
Signed-off-by: Mengqing Cao <cmq0113@163.com> Signed-off-by: SzymonOzog <szymon.ozog@aleph-alpha.com>
Signed-off-by: Mengqing Cao <cmq0113@163.com>
Signed-off-by: Mengqing Cao <cmq0113@163.com>
Signed-off-by: Mengqing Cao <cmq0113@163.com>
What does this pr do
This pr initailizing
local_rank
by the rank specified in argumentdevice
if it exists.FIX #12967
Bug description
While specifying device to cards except card-0, as following code, there'll cause an device conflict because the tensors (such as attn_bias) will be put on card-0 by default.
before this pr
after this pr