Skip to content

Conversation

@youkaichao
Copy link
Member

using f-string to make it easy to insert fields in the middle. previously the logger.info in vllm/engine/llm_engine.py is almost impossible to insert, if you don't want to pair the %s with the following args.

Signed-off-by: youkaichao <youkaichao@gmail.com>
@github-actions
Copy link

github-actions bot commented Dec 9, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao youkaichao merged commit 46004e8 into vllm-project:main Dec 9, 2024
13 of 16 checks passed
@youkaichao youkaichao deleted the dedup_logging branch December 9, 2024 01:28
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Signed-off-by: youkaichao <youkaichao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants