Fix logging of the vLLM Config #11143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The llm_engine logs its VllmConfig during initialization. A recent change to the logging has resulted in this log entry containing python object references rather than the actual details of the config, e.g.: VllmConfig(model_config=<vllm.config.ModelConfig object at 0x7f123b55db50>, cache_config=<vllm.config.CacheConfig object at 0x7f1239087920> This commit logs the VllmConfig using %s so that the string representation of the VllmConfig is logged, e.g.: model='amd/Mixtral-8x22B-Instruct-v0.1-FP8-KV', speculative_config=None, ...
JArnoldAMD
requested review from
alexm-redhat,
comaniac,
njhill,
youkaichao and
zhuohan123
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
gshtras
pushed a commit
to ROCm/vllm
that referenced
this pull request
Dec 12, 2024
gshtras
added a commit
to ROCm/vllm
that referenced
this pull request
Dec 12, 2024
Co-authored-by: Jeremy Arnold <103538711+JArnoldAMD@users.noreply.github.com>
sleepwalker2017
pushed a commit
to sleepwalker2017/vllm
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The llm_engine logs its VllmConfig during initialization. A recent change to the logging (#10999) has resulted in this log entry containing python object references rather than the actual details of the config, e.g.:
VllmConfig(model_config=<vllm.config.ModelConfig object at 0x7f123b55db50>, cache_config=<vllm.config.CacheConfig object at 0x7f1239087920>
This commit logs the VllmConfig using %s so that the string representation of the VllmConfig is logged, e.g.:
model='amd/Mixtral-8x22B-Instruct-v0.1-FP8-KV', speculative_config=None, ...