-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[PP] Correct cache size check #13873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
@andoorve can you help take a look? |
andoorve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense, thanks for taking a look!
|
Hi @DarkLight1337, |
|
Can you pull from latest main again? It might be fixed by #13890 |
Sure. |
|
Doesn't look like it's fixed. Let me open another PR. Updated: Opened #13895 |
Signed-off-by: Yang Zheng <zhengy.gator@gmail.com>
Head branch was pushed to by a user without write access
Signed-off-by: Yang Zheng <zhengy.gator@gmail.com>
Signed-off-by: Yang Zheng <zhengy.gator@gmail.com> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
Signed-off-by: Yang Zheng <zhengy.gator@gmail.com>

Single long prompt gets preempted(as cannot allocate slots) during decode and leads to recomput and incorrect output length.
Basically, it is because
CacheEnginesplits kv cache into separate pipeline byself.num_gpu_blocks //= parallel_config.pipeline_parallel_size. Long prompt does not get blocked even though it exceeds kv cache capacity. There should be the same logic for kv cache size check.