Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Feb 26, 2025

This PR fixes another problem introduced by the updated HF processor for Ultravox v0.5. For more context, see #13871 a mismatch in token counts introduced by #13871

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 26, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337
Copy link
Member Author

DarkLight1337 commented Feb 26, 2025

Actually it seems that the output token count has been changed by #13871, let me update the expected token count.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 changed the title [Bugfix] Revert to using Ultravox v0.4 for entrypoints tests [Bugfix] Update expected token counts for Ultravox tests Feb 26, 2025
@DarkLight1337
Copy link
Member Author

Tests pass locally - merging.

@vllm-bot vllm-bot merged commit 934bb99 into vllm-project:main Feb 26, 2025
6 of 13 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-audio-tests branch February 26, 2025 12:57
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants