Skip to content

[Refactor] Remove passthrough backend when generate grammar #15317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2025
Merged

[Refactor] Remove passthrough backend when generate grammar #15317

merged 3 commits into from
Mar 26, 2025

Conversation

@aarnphm
Copy link
Collaborator

@aarnphm aarnphm commented Mar 22, 2025 •
edited by github-actions bot
Loading

This PR remove the assertion on the job for create the grammar asynchronously, given that we already check for backend not to be None.

Signed-off-by: Aaron Pham contact@aarnphm.xyz

@aarnphm aarnphm requested review from mgoin and russellb as code owners March 22, 2025 01:21
@github-actions
Copy link

github-actions bot commented Mar 22, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 22, 2025
@aarnphm aarnphm requested a review from DarkLight1337 March 22, 2025 07:50
russellb
russellb reviewed Mar 24, 2025
View reviewed changes
@aarnphm aarnphm requested a review from russellb March 25, 2025 10:11
@aarnphm aarnphm force-pushed the chore/cleanup-async-pass-backend branch from c050687 to b27b92d Compare March 25, 2025 10:12
@russellb russellb added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 25, 2025
russellb
russellb approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@russellb russellb enabled auto-merge (squash) March 25, 2025 18:59
@aarnphm aarnphm changed the title [Refactor] Uses passthrough backend for generate grammar [Refactor] Remove passthrough backend when generate grammar Mar 25, 2025
@DarkLight1337
Copy link
Member

DarkLight1337 commented Mar 26, 2025

Can you merge from main to see if this V1 test persists?

aarnphm added 3 commits March 26, 2025 11:02
@aarnphm @russellb
chore: use passed in backend instead of self
b941027 
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@aarnphm @russellb
revert: remove extra changes [skip ci]
b94c40c 
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@aarnphm @russellb
chore: remove parameters
425a3dc 
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@russellb russellb force-pushed the chore/cleanup-async-pass-backend branch from b27b92d to 425a3dc Compare March 26, 2025 15:03
@russellb
Copy link
Member

russellb commented Mar 26, 2025

Can you merge from main to see if this V1 test persists?

I just rebased the PR on main

@russellb russellb merged commit 733e7c9 into vllm-project:main Mar 26, 2025
32 checks passed
@aarnphm aarnphm deleted the chore/cleanup-async-pass-backend branch March 27, 2025 02:12
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@aarnphm @Alex4210987
[Refactor] Remove unnecessary backend parameter in structured output …
8e4f694 
…interface (vllm-project#15317)

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@aarnphm @lulmer
[Refactor] Remove unnecessary backend parameter in structured output …
50c0788 
…interface (vllm-project#15317)

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@aarnphm @lk-chen
[Refactor] Remove unnecessary backend parameter in structured output …
c8f70fd 
…interface (vllm-project#15317)

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@aarnphm @shreyankg
[Refactor] Remove unnecessary backend parameter in structured output …
ca1e855 
…interface (vllm-project#15317)

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@aarnphm
[Refactor] Remove unnecessary backend parameter in structured output …
1330b31 
…interface (vllm-project#15317)

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russellb russellb russellb approved these changes

@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed structured-output v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aarnphm @DarkLight1337 @russellb