Skip to content

[Refactor] Remove passthrough backend when generate grammar #15317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2025
Merged

[Refactor] Remove passthrough backend when generate grammar #15317

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b941027
chore: use passed in backend instead of self
aarnphm Mar 22, 2025
b94c40c
revert: remove extra changes [skip ci]
aarnphm Mar 22, 2025
425a3dc
chore: remove parameters
aarnphm Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions vllm/v1/structured_output/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from __future__ import annotations

import multiprocessing
from concurrent.futures import Future, ThreadPoolExecutor
from concurrent.futures import ThreadPoolExecutor
from typing import TYPE_CHECKING, Optional

from vllm.config import VllmConfig
Expand Down Expand Up @@ -57,13 +57,13 @@ def grammar_init(self, request: Request) -> None:
raise ValueError(
f"Unsupported structured output backend: {backend_name}")

grammar: Future[StructuredOutputGrammar] = self.executor.submit(
self._async_create_grammar, request, self.backend)
grammar = self.executor.submit(self._async_create_grammar, request)
request.structured_output_request.grammar = grammar # type: ignore[assignment]

def _async_create_grammar(
self, request: Request,
backend: StructuredOutputBackend) -> StructuredOutputGrammar:
self,
request: Request,
) -> StructuredOutputGrammar:
key = request.structured_output_request.structured_output_key # type: ignore[union-attr]

# Note that the request was validated in the engine core client,
Expand Down