Skip to content

fix: Comments to English for better dev experience #15768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2025
Merged

fix: Comments to English for better dev experience #15768

merged 2 commits into from
Mar 30, 2025

Conversation

@yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Mar 30, 2025 •
edited by github-actions bot
Loading

No description provided.

@yihong0618
fix: Comments to English for better dev experience
40fb3d4 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@github-actions
Copy link

github-actions bot commented Mar 30, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@yihong0618
fix: ci lint
c6c796c 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
jeejeelee
jeejeelee reviewed Mar 30, 2025
View reviewed changes
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 30, 2025
@jeejeelee jeejeelee enabled auto-merge (squash) March 30, 2025 13:31
@WoosukKwon WoosukKwon disabled auto-merge March 30, 2025 17:47
@WoosukKwon WoosukKwon merged commit 70fedd0 into vllm-project:main Mar 30, 2025
39 of 43 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@yihong0618 @Alex4210987
fix: Comments to English for better dev experience (vllm-project#15768)
8b90a33 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@yihong0618 @lulmer
fix: Comments to English for better dev experience (vllm-project#15768)
9de3323 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@yihong0618 @lk-chen
fix: Comments to English for better dev experience (vllm-project#15768)
22b3da8 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@yihong0618 @shreyankg
fix: Comments to English for better dev experience (vllm-project#15768)
c808dcf 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@yihong0618
fix: Comments to English for better dev experience (vllm-project#15768)
1e9d1ae 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yihong0618 @jeejeelee @WoosukKwon