Skip to content

fix: Comments to English for better dev experience #15768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2025
Merged

fix: Comments to English for better dev experience #15768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40fb3d4
fix: Comments to English for better dev experience
yihong0618 Mar 30, 2025
c6c796c
fix: ci lint
yihong0618 Mar 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/model_executor/models/deepseek_vl2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ def _pixel_values_to_embedding(
_, hw, n_dim = images_embeds.shape
h = w = int(hw**0.5)

# 根据self.tile_tag & self.global_view_pos填充image token sequence
# fill image token based on self.tile_tag & self.global_view_pos
tile_index = 0
vision_embeddings = []
for jdx in range(images_spatial_crop.size(0)):
Expand Down
2 changes: 1 addition & 1 deletion vllm/transformers_utils/processors/deepseek_vl2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ def process_one(
input_ids[input_ids < 0] = self.pad_id

if inference_mode:
# 去掉结尾的eos token
# Remove the ending eos token
assert input_ids[-1] == self.eos_id
input_ids = input_ids[:-1]
target_ids = target_ids[:-1]
Expand Down