Skip to content

[V1] TPU - Fix fused MOE #15834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

[V1] TPU - Fix fused MOE #15834

merged 1 commit into from
Apr 1, 2025

Conversation

@alexm-redhat
Copy link
Collaborator

A small fix to allow fused MOE to run on TPUs.

@alexm-redhat
[V1] TPU - Fix fused MOE
abae9a9 
Signed-off-by: Alexander Matveev <amatveev@redhat.com>
@alexm-redhat alexm-redhat self-assigned this Mar 31, 2025
@alexm-redhat alexm-redhat requested a review from mgoin March 31, 2025 19:34
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin added tpu Related to Google TPUs ready ONLY add when PR is ready to merge/full CI is needed labels Mar 31, 2025
@mgoin mgoin enabled auto-merge (squash) March 31, 2025 19:53
@mergify mergify bot removed the tpu Related to Google TPUs label Mar 31, 2025
yaochengji
yaochengji approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@yaochengji yaochengji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bvrockwell
Copy link
Contributor

Wow this is great @alexm-redhat thanks for looking into this

@vllm-bot vllm-bot merged commit 7e4e709 into main Apr 1, 2025
44 of 46 checks passed
@vllm-bot vllm-bot deleted the v1_tpu_fused_moe_fix branch April 1, 2025 05:58
@ywang96 ywang96 mentioned this pull request Apr 2, 2025
Merged
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@alexm-redhat @Alex4210987
[V1] TPU - Fix fused MOE (vllm-project#15834)
1dcd3b8 
Signed-off-by: Alexander Matveev <amatveev@redhat.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@alexm-redhat @lulmer
[V1] TPU - Fix fused MOE (vllm-project#15834)
1a8832d 
Signed-off-by: Alexander Matveev <amatveev@redhat.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@alexm-redhat @lk-chen
[V1] TPU - Fix fused MOE (vllm-project#15834)
df45732 
Signed-off-by: Alexander Matveev <amatveev@redhat.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@alexm-redhat @shreyankg
[V1] TPU - Fix fused MOE (vllm-project#15834)
24c83f4 
Signed-off-by: Alexander Matveev <amatveev@redhat.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@alexm-redhat
[V1] TPU - Fix fused MOE (vllm-project#15834)
fa48ae0 
Signed-off-by: Alexander Matveev <amatveev@redhat.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

@mgoin mgoin mgoin approved these changes

@yaochengji yaochengji yaochengji approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

Assignees

@alexm-redhat alexm-redhat

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alexm-redhat @bvrockwell @tlrmchlsmth @mgoin @yaochengji @vllm-bot