-
-
Couldn't load subscription status.
- Fork 10.8k
[V1][Bugfix] Fix typo in MoE TPU checking #15927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
This also leads to a torch.compile error, see: #15871 (comment) |
|
I manually enabled 2 node 4 GPU test and confirmed this PR fixed it. |
Signed-off-by: Roger Wang <ywang@roblox.com> Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
Signed-off-by: Roger Wang <ywang@roblox.com> Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Roger Wang <ywang@roblox.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Fixes the typo in #15834 that breaks two-node 4GPU test on CI since method object is always evaluated to
Truein Python when it's not being called.Caught this bug from CI errors since we don't have TPU on CI but it's calling
forward_tpu