Skip to content

Conversation

@ywang96
Copy link
Member

@ywang96 ywang96 commented Apr 2, 2025

Fixes the typo in #15834 that breaks two-node 4GPU test on CI since method object is always evaluated to True in Python when it's not being called.

Caught this bug from CI errors since we don't have TPU on CI but it's calling forward_tpu

[2025-04-01T08:01:38Z] ERROR 04-01 01:01:38 [core.py:376]   File "/usr/local/lib/python3.12/dist-packages/vllm/model_executor/layers/fused_moe/layer.py", line 819, in forward
[2025-04-01T08:01:38Z] ERROR 04-01 01:01:38 [core.py:376]     return self.forward_impl(hidden_states, router_logits)
[2025-04-01T08:01:38Z] ERROR 04-01 01:01:38 [core.py:376]   File "/usr/local/lib/python3.12/dist-packages/vllm/model_executor/layers/fused_moe/layer.py", line 838, in forward_impl
[2025-04-01T08:01:38Z] ERROR 04-01 01:01:38 [core.py:376]     final_hidden_states = self.quant_method.apply(
[2025-04-01T08:01:38Z] ERROR 04-01 01:01:38 [core.py:376]   File "/usr/local/lib/python3.12/dist-packages/vllm/model_executor/layers/fused_moe/layer.py", line 161, in apply
[2025-04-01T08:01:38Z] ERROR 04-01 01:01:38 [core.py:376]     return self.forward(x=x,
[2025-04-01T08:01:38Z] ERROR 04-01 01:01:38 [core.py:376]   File "/usr/local/lib/python3.12/dist-packages/vllm/model_executor/custom_op.py", line 25, in forward
[2025-04-01T08:01:38Z] ERROR 04-01 01:01:38 [core.py:376]     return self._forward_method(*args, **kwargs)
[2025-04-01T08:01:38Z] ERROR 04-01 01:01:38 [core.py:376]   File "/usr/local/lib/python3.12/dist-packages/vllm/model_executor/layers/fused_moe/layer.py", line 295, in forward_tpu
[2025-04-01T08:01:38Z] ERROR 04-01 01:01:38 [core.py:376]     assert custom_routing_function is None

Signed-off-by: Roger Wang <ywang@roblox.com>
@github-actions
Copy link

github-actions bot commented Apr 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 2, 2025
@jeejeelee
Copy link
Collaborator

This also leads to a torch.compile error, see: #15871 (comment)

@ywang96
Copy link
Member Author

ywang96 commented Apr 2, 2025

I manually enabled 2 node 4 GPU test and confirmed this PR fixed it.

@WoosukKwon WoosukKwon merged commit 0e00d40 into main Apr 2, 2025
40 of 45 checks passed
@WoosukKwon WoosukKwon deleted the v1-tpu-moe branch April 2, 2025 06:46
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: xinyuxiao <xinyuxiao2024@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
Signed-off-by: Roger Wang <ywang@roblox.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Signed-off-by: Roger Wang <ywang@roblox.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants