Skip to content

[V1][Spec Decode] Make eagle compatible with prefix caching. #17137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 27, 2025
Merged

[V1][Spec Decode] Make eagle compatible with prefix caching. #17137

merged 8 commits into from
Apr 27, 2025

Conversation

@LiuXiaoxuanPKU
Copy link
Collaborator

@LiuXiaoxuanPKU LiuXiaoxuanPKU commented Apr 24, 2025 •
edited by github-actions bot
Loading

Task 7 of #15901

Design doc.

@LiuXiaoxuanPKU
version
c7c1bbc 
Signed-off-by: LiuXiaoxuanPKU <lilyliupku@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Apr 24, 2025
LiuXiaoxuanPKU
LiuXiaoxuanPKU commented Apr 24, 2025
View reviewed changes
LiuXiaoxuanPKU
LiuXiaoxuanPKU commented Apr 25, 2025
View reviewed changes
LiuXiaoxuanPKU
LiuXiaoxuanPKU commented Apr 25, 2025
View reviewed changes
@LiuXiaoxuanPKU
fix comments
a77256f 
Signed-off-by: LiuXiaoxuanPKU <lilyliupku@gmail.com>
@mergify
Copy link

mergify bot commented Apr 25, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @LiuXiaoxuanPKU.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 25, 2025
@LiuXiaoxuanPKU
Merge branch 'main' of github.com:vllm-project/vllm
6faf10b
@LiuXiaoxuanPKU
merge
9ce6dde 
Signed-off-by: LiuXiaoxuanPKU <lilyliupku@gmail.com>
@mergify mergify bot removed the needs-rebase label Apr 25, 2025
@LiuXiaoxuanPKU LiuXiaoxuanPKU added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 25, 2025
@mergify
Copy link

mergify bot commented Apr 25, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @LiuXiaoxuanPKU.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 25, 2025
WoosukKwon
WoosukKwon reviewed Apr 25, 2025
View reviewed changes
@WoosukKwon WoosukKwon mentioned this pull request Apr 26, 2025
Merged
@LiuXiaoxuanPKU
fix comments/
9c1d37c 
Signed-off-by: LiuXiaoxuanPKU <lilyliupku@gmail.com>
@LiuXiaoxuanPKU
minor
1f2a630 
Signed-off-by: LiuXiaoxuanPKU <lilyliupku@gmail.com>
@LiuXiaoxuanPKU
Merge branch 'main' of github.com:vllm-project/vllm
ee38dff
@LiuXiaoxuanPKU
merge
717aebb 
Signed-off-by: LiuXiaoxuanPKU <lilyliupku@gmail.com>
@mergify mergify bot removed the needs-rebase label Apr 27, 2025
@WoosukKwon WoosukKwon merged commit 20e489e into main Apr 27, 2025
45 checks passed
@WoosukKwon WoosukKwon deleted the eagle-prefix branch April 27, 2025 16:29
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@LiuXiaoxuanPKU @dbyoung18
[V1][Spec Decode] Make eagle compatible with prefix caching. (vllm-pr…
f20618f 
…oject#17137)

Signed-off-by: LiuXiaoxuanPKU <lilyliupku@gmail.com>
@heheda12345 heheda12345 mentioned this pull request Apr 29, 2025
Merged
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@LiuXiaoxuanPKU @lk-chen
[V1][Spec Decode] Make eagle compatible with prefix caching. (vllm-pr…
a02a76a 
…oject#17137)

Signed-off-by: LiuXiaoxuanPKU <lilyliupku@gmail.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@LiuXiaoxuanPKU @adobrzyn
[V1][Spec Decode] Make eagle compatible with prefix caching. (vllm-pr…
2bb6b6f 
…oject#17137)

Signed-off-by: LiuXiaoxuanPKU <lilyliupku@gmail.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@LiuXiaoxuanPKU
[V1][Spec Decode] Make eagle compatible with prefix caching. (vllm-pr…
40410da 
…oject#17137)

Signed-off-by: LiuXiaoxuanPKU <lilyliupku@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@LiuXiaoxuanPKU
[V1][Spec Decode] Make eagle compatible with prefix caching. (vllm-pr…
e9a856f 
…oject#17137)

Signed-off-by: LiuXiaoxuanPKU <lilyliupku@gmail.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LiuXiaoxuanPKU @WoosukKwon