Skip to content

Conversation

@heheda12345
Copy link
Collaborator

@heheda12345 heheda12345 commented Apr 29, 2025

#17137 drops the last matched block to support eagle. This strategy is not correct for sliding window layers.

When sliding window size is 4 and block_size is 2, we need at least 2 blocks. However,
find_longest_cache_hit of sliding_window_layers will return [NULL_BLOCK, NULL_BLOCK, BLOCK_A, BLOCK_B], and the blocks are changed to [NULL_BLOCK, NULL_BLOCK, BLOCK_A] due to eagle, which is not correct.

To fix the bug, this pr moves the logic to handle eagle into specialized_manager. This pr also fixes an outdated comment in test_eagle_enabled_removes_last_block

Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Signed-off-by: Chen Zhang <zhangch99@outlook.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Apr 29, 2025
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for finding the bug and fixing it.

@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 30, 2025
@WoosukKwon WoosukKwon enabled auto-merge (squash) April 30, 2025 08:36
Signed-off-by: Chen Zhang <zhangch99@outlook.com>
@WoosukKwon WoosukKwon disabled auto-merge April 30, 2025 17:06
@WoosukKwon WoosukKwon enabled auto-merge (squash) April 30, 2025 17:06
@WoosukKwon WoosukKwon merged commit 81ecf42 into vllm-project:main Apr 30, 2025
43 of 44 checks passed
radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
…ching (vllm-project#17398)

Signed-off-by: Chen Zhang <zhangch99@outlook.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…ching (vllm-project#17398)

Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
…ching (vllm-project#17398)

Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants