Skip to content

Conversation

@aarnphm
Copy link
Collaborator

@aarnphm aarnphm commented Apr 29, 2025

This PR address #17416 where it should be passed *args accordingly to logger

to format with %s instead of f-string

Signed-off-by: Aaron Pham contact@aarnphm.xyz

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

Args can only be Hashable, not Any

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@aarnphm aarnphm requested a review from hmellor April 30, 2025 10:04
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@mergify mergify bot added multi-modality Related to multi-modality (#4194) structured-output labels Apr 30, 2025
@mergify
Copy link

mergify bot commented Apr 30, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @aarnphm.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

aarnphm added 2 commits April 30, 2025 06:45
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@mergify mergify bot removed the needs-rebase label Apr 30, 2025
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@aarnphm aarnphm requested a review from DarkLight1337 April 30, 2025 10:49
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@aarnphm aarnphm requested a review from hmellor April 30, 2025 10:53
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 30, 2025 11:04
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 30, 2025
@vllm-bot vllm-bot merged commit da4e768 into vllm-project:main Apr 30, 2025
72 of 76 checks passed
@aarnphm aarnphm deleted the fix/logging-args-support branch April 30, 2025 15:18
radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed structured-output

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants