Skip to content

Fix call to logger.info_once #17416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Fix call to logger.info_once #17416

merged 1 commit into from
Apr 30, 2025

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Apr 29, 2025

logger.info_once is a custom method which does not support %s like a regular logger.info

@hmellor
Fix call to logger.info_once
74f90d8 
`logger.info_once` is a custom method which does not support `%s` like a regular `logger.info`

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor hmellor requested review from mgoin and russellb as code owners April 29, 2025 22:17
@github-actions
Copy link

github-actions bot commented Apr 29, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor mentioned this pull request Apr 29, 2025
Merged
aarnphm
aarnphm reviewed Apr 29, 2025
View reviewed changes
vllm/model_executor/guided_decoding/xgrammar_decoding.py
if model_with_warn is not None and any_whitespace:
logger.info_once(
"%s model detected, consider setting "
f"{model_with_warn} model detected, consider setting "
Copy link
Collaborator

@aarnphm aarnphm Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we fix info_once to support *args instead?

f-string with logger is considered not the best practice iirc.

Copy link
Member Author

@hmellor hmellor Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but I think we should patch it first so users don't see errors

Copy link
Collaborator

@aarnphm aarnphm Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17425 cc @hmellor

@russellb russellb enabled auto-merge (squash) April 29, 2025 23:15
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 29, 2025
@aarnphm aarnphm mentioned this pull request Apr 29, 2025
Merged
@vllm-bot vllm-bot merged commit d1f569b into vllm-project:main Apr 30, 2025
66 of 68 checks passed
radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
@hmellor @radeksm
Fix call to logger.info_once (vllm-project#17416)
31b9eae 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor
Fix call to logger.info_once (vllm-project#17416)
6d2f2fb 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@hmellor
Fix call to logger.info_once (vllm-project#17416)
2ebb77f 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aarnphm aarnphm aarnphm left review comments

@russellb russellb russellb approved these changes

@mgoin mgoin Awaiting requested review from mgoin

+1 more reviewer

@lk-chen lk-chen lk-chen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed structured-output

Projects

Structured Output
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hmellor @russellb @lk-chen @aarnphm @vllm-bot