Skip to content

Fix call to logger.info_once #17416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Fix call to logger.info_once #17416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vllm/model_executor/guided_decoding/xgrammar_decoding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,9 @@ def from_guided_params(cls,

if model_with_warn is not None and any_whitespace:
logger.info_once(
"%s model detected, consider setting "
f"{model_with_warn} model detected, consider setting "
Copy link
Collaborator

@aarnphm aarnphm Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we fix info_once to support *args instead?

f-string with logger is considered not the best practice iirc.

Copy link
Member Author

@hmellor hmellor Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but I think we should patch it first so users don't see errors

Copy link
Collaborator

@aarnphm aarnphm Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17425 cc @hmellor

"`disable_any_whitespace` to prevent runaway generation "
"of whitespaces.", model_with_warn)
"of whitespaces.")
# Validate the schema and raise ValueError here if it is invalid.
# This is to avoid exceptions in model execution, which will crash
# the engine worker process.
Expand Down