-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
[CI] Fix Nightly Failures #17997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fix Nightly Failures #17997
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: rshaw@neuralmagic.com <robertgshaw2@gmail.com>
| # TODO(@darklight): Remove this skip once the CI is fixed. | ||
| pytest.skip(reason=("Failing in the CI due to env variable mismatch. " | ||
| "Setting the XFORMERS does not seem to be working " | ||
| "in the CI environment properly."), | ||
| allow_module_level=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I have no idea why this is happening. The test passes locally...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its due to some env variable getting set that overrides the attn backend gloablly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #18109 to work around this
|
This pull request has merge conflicts that must be resolved before it can be |
| "ATTN_BACKEND", | ||
| [ | ||
| "FLASH_ATTN", | ||
| # "FLASHINFER", @mgoin is looking at this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be resolved by #18086
|
This pull request has merge conflicts that must be resolved before it can be |
SUMMARY: