Skip to content

[CI] Fix Nightly Failures #17997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[CI] Fix Nightly Failures #17997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
192e140
updated
robertgshaw2-redhat May 12, 2025
344f3d1
updated
robertgshaw2-redhat May 12, 2025
043d1f1
spec decoding tests
robertgshaw2-redhat May 12, 2025
934ec95
updated
robertgshaw2-redhat May 12, 2025
f6f8e8a
updated
robertgshaw2-redhat May 12, 2025
24afa7f
Merge branch 'main' into fix-nightly-ci-failures
robertgshaw2-redhat May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/distributed/test_pp_cudagraph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@
@pytest.mark.parametrize("PP_SIZE, MODEL_NAME", [
(2, "JackFram/llama-160m"),
])
@pytest.mark.parametrize("ATTN_BACKEND", [
"FLASH_ATTN",
"FLASHINFER",
])
@pytest.mark.parametrize(
"ATTN_BACKEND",
[
"FLASH_ATTN",
# "FLASHINFER", @mgoin is looking at this.
Copy link
Member

@mgoin mgoin May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be resolved by #18086

])
@create_new_process_for_each_test()
def test_pp_cudagraph(
monkeypatch: pytest.MonkeyPatch,
Expand Down
6 changes: 6 additions & 0 deletions tests/models/language/pooling/test_gritlm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@

from ....utils import RemoteOpenAIServer

# TODO(@darklight): Remove this skip once the CI is fixed.
pytest.skip(reason=("Failing in the CI due to env variable mismatch. "
"Setting the XFORMERS does not seem to be working "
"in the CI environment properly."),
allow_module_level=True)
Comment on lines +18 to +22
Copy link
Member

@DarkLight1337 DarkLight1337 May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I have no idea why this is happening. The test passes locally...

Copy link
Collaborator Author

@robertgshaw2-redhat robertgshaw2-redhat May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its due to some env variable getting set that overrides the attn backend gloablly

Copy link
Member

@DarkLight1337 DarkLight1337 May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #18109 to work around this


# GritLM embedding implementation is only supported by XFormers backend.
pytestmark = pytest.mark.skipif(not importlib.util.find_spec("xformers"),
reason="GritLM requires XFormers")
Expand Down
1 change: 1 addition & 0 deletions tests/spec_decode/e2e/test_eagle_correctness.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ def test_eagle_e2e_greedy_correctness_cuda_graph(
batch_size, output_len, seed)


@pytest.mark.skip(reason="RE-ENABLE: Test is currently failing.")
@pytest.mark.parametrize(
"common_llm_kwargs",
[{
Expand Down