[Fix] bump mistral common to support magistral #19533

princepride · 2025-06-12T07:55:08Z

Essential Elements of an Effective PR Description Checklist

Purpose

Fix [Bug]: Latest Mistral Model requires v11 from mistral_common #19495 .

Test Plan

Test command:
vllm serve mistralai/Magistral-Small-2506 --tokenizer_mode mistral --config_format mistral --load_format mistral --tool-call-parser mistral --enable-auto-tool-choice

Test Result

Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>

github-actions · 2025-06-12T07:55:18Z

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

gemini-code-assist

Summary of Changes

Hello @princepride, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issue #19495 by updating the required version of the mistral_common dependency. This change ensures compatibility or leverages new features/fixes available in version 1.6.0 of the library.

Highlights

Dependency Update: Updated the mistral_common[opencv] dependency version from >= 1.5.4 to >= 1.6.0 in both the common and test requirements files.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request updates the mistral_common[opencv] dependency from version >=1.5.4 to >=1.6.0 in requirements/common.txt and requirements/test.in. I've suggested considering a more precise version pin (e.g., ==1.6.0) for mistral_common to enhance stability.

houseroad

Thanks for the contribution. Could you paste the test plan (such as verifying the issue is fixed)?

Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>

princepride · 2025-06-12T08:50:48Z

aarnphm

ok, this makes sense to me, but can you update the description of the PR with the image you provided, following the default PR format?

Thanks.

gaby

LGTM, currently unable to use Magistral because of this

princepride · 2025-06-12T11:50:14Z


[2025-06-12T09:46:20Z] ==================================== ERRORS ====================================
--
  | [2025-06-12T09:46:20Z] _____ ERROR collecting tests/models/multimodal/generation/test_pixtral.py ______
  | [2025-06-12T09:46:20Z] models/multimodal/generation/test_pixtral.py:114: in <module>
  | [2025-06-12T09:46:20Z]     _create_engine_inputs(IMG_URLS[:1]),
  | [2025-06-12T09:46:20Z] models/multimodal/generation/test_pixtral.py:73: in _create_engine_inputs
  | [2025-06-12T09:46:20Z]     tokenizer = MistralTokenizer.from_model("pixtral")
  | [2025-06-12T09:46:20Z] /usr/local/lib/python3.12/dist-packages/mistral_common/tokens/tokenizers/mistral.py:189: in from_model
  | [2025-06-12T09:46:20Z]     return tokenizer_cls()
  | [2025-06-12T09:46:20Z] /usr/local/lib/python3.12/dist-packages/mistral_common/tokens/tokenizers/mistral.py:362: in <lambda>
  | [2025-06-12T09:46:20Z]     "pixtral": lambda: MistralTokenizer.v3(is_tekken=True, is_mm=True),
  | [2025-06-12T09:46:20Z] /usr/local/lib/python3.12/dist-packages/mistral_common/tokens/tokenizers/mistral.py:142: in v3
  | [2025-06-12T09:46:20Z]     return cls.from_file(str(cls._data_path() / tokenizer_name), mode=ValidationMode.test)
  | [2025-06-12T09:46:20Z] /usr/local/lib/python3.12/dist-packages/mistral_common/tokens/tokenizers/mistral.py:239: in from_file
  | [2025-06-12T09:46:20Z]     raise TokenizerException(f"Unrecognized tokenizer file: {tokenizer_filename}")
  | [2025-06-12T09:46:20Z] E   mistral_common.exceptions.TokenizerException: Unrecognized tokenizer file: /usr/local/lib/python3.12/dist-packages/mistral_common/data/tekken_240911.json

@houseroad Some unit test failed. What should I do?

gaby · 2025-06-12T11:58:35Z

@princepride The test_pixtral.py file probable needs to be updated.

Here's the PR for v11 from mistral_common https://github.com/mistralai/mistral-common/pull/91/files

princepride · 2025-06-12T12:32:32Z

@princepride The test_pixtral.py file probable needs to be updated.

Here's the PR for v11 from mistral_common https://github.com/mistralai/mistral-common/pull/91/files

That's weird. I checked this PR, it sames the pixtral tokenizer mapping didn't make any change, and I checked the source code, the tekken_240911.json file under the mistral_common/data folder: https://github.com/mistralai/mistral-common/tree/main/src/mistral_common/data,

princepride · 2025-06-12T13:08:41Z

@houseroad 😓 seems it's a bug in mistral_common==1.6.0: mistralai/mistral-common#94

gaby · 2025-06-12T13:10:00Z

@princepride Hopefully they fix it quickly

patrickvonplaten · 2025-06-12T14:47:45Z

Nice catch with the data folder - that's indeed needed for the tests. Fixing now. Should be done in 1h

patrickvonplaten · 2025-06-12T15:23:51Z

requirements/common.txt

 gguf >= 0.13.0
 importlib_metadata; python_version < '3.10'
-mistral_common[opencv] >= 1.5.4
+mistral_common[opencv] >= 1.6.0


Suggested change

mistral_common[opencv] >= 1.6.0

mistral_common[opencv] >= 1.6.2

requirements/test.in

houseroad · 2025-06-12T15:25:17Z

Let's update the version and re-trigger the tests :-)

patrickvonplaten · 2025-06-12T15:27:31Z

Sorry about that - we should have read the uv docs better before switching 😅

requirements/test.txt

Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>

gemini-code-assist · 2025-06-13T01:40:17Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

princepride · 2025-06-13T01:46:38Z

@houseroad Hmm, that's weird, the Unit test failed, it seems not a problem of my code.

houseroad · 2025-06-13T03:20:58Z

The failed test shouldn't be related.

gemini-code-assist · 2025-06-13T05:28:15Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

gaby · 2025-06-15T23:57:12Z

@patrickvonplaten @patrickvonplaten Even with this Magistral doesn't work with vLLM. It goes into a thinking loop.

Similar issue reported here: https://huggingface.co/mistralai/Magistral-Small-2506/discussions/15

fix vllm-project#19495

cfa83f2

Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>

gemini-code-assist bot reviewed Jun 12, 2025

View reviewed changes

mergify bot added the ci/build label Jun 12, 2025

gemini-code-assist bot reviewed Jun 12, 2025

View reviewed changes

houseroad reviewed Jun 12, 2025

View reviewed changes

xx

c1f8937

Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>

aarnphm changed the title ~~fix #19495~~ [Fix] bump mistral common to support magistral Jun 12, 2025

princepride requested a review from houseroad June 12, 2025 08:51

aarnphm approved these changes Jun 12, 2025

View reviewed changes

princepride requested a review from aarnphm June 12, 2025 09:01

aarnphm enabled auto-merge (squash) June 12, 2025 09:06

aarnphm approved these changes Jun 12, 2025

View reviewed changes

github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 12, 2025

gaby approved these changes Jun 12, 2025

View reviewed changes

patrickvonplaten reviewed Jun 12, 2025

View reviewed changes

requirements/test.in Outdated Show resolved Hide resolved

patrickvonplaten reviewed Jun 12, 2025

View reviewed changes

requirements/test.txt Outdated Show resolved Hide resolved

because no data folder in mistral-common==1.6.0, switch to 1.6.2

4c73ebe

Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>

auto-merge was automatically disabled June 12, 2025 15:28
Head branch was pushed to by a user without write access

aarnphm removed the ready ONLY add when PR is ready to merge/full CI is needed label Jun 12, 2025

aarnphm added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 12, 2025

houseroad enabled auto-merge (squash) June 13, 2025 03:21

houseroad mentioned this pull request Jun 13, 2025

[CI/Build] Fix torch nightly CI dependencies part 2 #19589

Merged

vllm-bot merged commit ace5cda into vllm-project:main Jun 13, 2025
94 of 96 checks passed

gaby mentioned this pull request Jun 13, 2025

Updated mistral_common for latest mistral support #19496

Closed

EwoutH mentioned this pull request Aug 31, 2025

[BUG] Support Mistral tokenisation EuroEval/EuroEval#1134

Closed

	mistral_common[opencv] >= 1.6.0
	mistral_common[opencv] >= 1.6.2

Uh oh!

[Fix] bump mistral common to support magistral #19533

[Fix] bump mistral common to support magistral #19533

Uh oh!

Conversation

princepride commented Jun 12, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Essential Elements of an Effective PR Description Checklist

Purpose

Test Plan

Test Result

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

houseroad left a comment

Choose a reason for hiding this comment

Uh oh!

princepride commented Jun 12, 2025

Uh oh!

aarnphm left a comment

Choose a reason for hiding this comment

Uh oh!

gaby left a comment

Choose a reason for hiding this comment

Uh oh!

princepride commented Jun 12, 2025

Uh oh!

gaby commented Jun 12, 2025

Uh oh!

princepride commented Jun 12, 2025

Uh oh!

princepride commented Jun 12, 2025

Uh oh!

gaby commented Jun 12, 2025

Uh oh!

patrickvonplaten commented Jun 12, 2025

Uh oh!

patrickvonplaten Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

houseroad commented Jun 12, 2025

Uh oh!

patrickvonplaten commented Jun 12, 2025

Uh oh!

Uh oh!

gemini-code-assist bot commented Jun 13, 2025

Uh oh!

princepride commented Jun 13, 2025

Uh oh!

houseroad commented Jun 13, 2025

Uh oh!

Uh oh!

gemini-code-assist bot commented Jun 13, 2025

Uh oh!

gaby commented Jun 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

princepride commented Jun 12, 2025 •

edited by github-actions bot

Loading