Skip to content

[CI/Build] Fix torch nightly CI dependencies part 2 #19589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2025
Merged

[CI/Build] Fix torch nightly CI dependencies part 2 #19589

merged 1 commit into from
Jun 15, 2025

Conversation

@zou3519
Copy link
Collaborator

@zou3519 zou3519 commented Jun 13, 2025 •
edited by github-actions bot
Loading

Summary:
This should fix the last dependency error in the torch nightly CI, the other test failures are other issues. This PR pins mistral-common in the nightly_torch_test.txt to the same version as the requirements/test.txt

Test Plan:

  • wait for CI

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jun 13, 2025

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@zou3519 zou3519 added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 13, 2025
@github-actions
Copy link

github-actions bot commented Jun 13, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jun 13, 2025
@zou3519 zou3519 marked this pull request as ready for review June 13, 2025 02:20
houseroad
houseroad reviewed Jun 13, 2025
View reviewed changes
Copy link
Collaborator

@houseroad houseroad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rebase on top of #19533?

@gaby
Copy link

gaby commented Jun 13, 2025

Let's rebase on top of #19533?

Yes please, the new common package is needed for the newly released reasoning model Magistral.

@zou3519
[CI/Build] Fix torch nightly CI dependencies part 2
1f941e1 
Summary:
This should fix the last dependency error in the torch nightly CI, the
other test failures are other issues. This PR pins mistral-common in the
nightly_torch_test.txt to the same version as the requirements/test.txt

Test Plan:
- wait for CI

Signed-off-by: Richard Zou <zou3519@gmail.com>
@zou3519 zou3519 force-pushed the torch_nightly_pin branch from cb67cc9 to 1f941e1 Compare June 13, 2025 13:18
@zou3519
Copy link
Collaborator Author

zou3519 commented Jun 13, 2025

Thanks, I've rebased this PR.

@houseroad houseroad merged commit 91b2c17 into vllm-project:main Jun 15, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houseroad houseroad houseroad approved these changes

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zou3519 @gaby @houseroad