[ROCm][Fix] Fix rocm build caused by #23791 #23847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: charlifu <charlifu@amd.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes a build issue on ROCm caused by an unused variable. The proposed change adds [[maybe_unused]] to suppress the compiler warning. While this works, a cleaner solution would be to remove the unused variable entirely, as it appears to be dead code. I've suggested this change.
csrc/cache_kernels.cu
Outdated
|
|
||
| const bool is_active_split = (split_start < tot_slots); | ||
| const bool is_last_split = (split_end == tot_slots); | ||
| [[maybe_unused]] const bool is_last_split = (split_end == tot_slots); |
There was a problem hiding this comment.
Since is_last_split is not used anywhere in this kernel, it's better to remove this line completely rather than marking it as [[maybe_unused]]. This helps in keeping the code clean by removing dead code.
hongxiayang
approved these changes
Aug 28, 2025
|
@charlifu if the variable is not used, you can safely delete it. |
Signed-off-by: charlifu <charlifu@amd.com>
gshtras
approved these changes
Aug 28, 2025
yewentao256
approved these changes
Aug 28, 2025
eicherseiji
pushed a commit
to eicherseiji/vllm
that referenced
this pull request
Sep 9, 2025
…#23847) Signed-off-by: charlifu <charlifu@amd.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…#23847) Signed-off-by: charlifu <charlifu@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler is rejecting an unused var.