Skip to content

[ROCm][Fix] Fix rocm build caused by #23791 #23847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 29, 2025
Merged

[ROCm][Fix] Fix rocm build caused by #23791 #23847

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
80d6660
fix rocm build
charlifu Aug 28, 2025
824a92f
Merge branch 'main' into fix_rocm_build
charlifu Aug 28, 2025
11baade
remove unused var
charlifu Aug 28, 2025
9aa4ace
Merge branch 'main' into fix_rocm_build
charlifu Aug 28, 2025
2883a25
Merge branch 'main' into fix_rocm_build
charlifu Aug 28, 2025
eb69d6f
Merge branch 'main' into fix_rocm_build
charlifu Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion csrc/cache_kernels.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,7 +913,6 @@ __global__ void cp_gather_cache(
const int32_t split_end = min((split + 1) * split_slots, tot_slots);

const bool is_active_split = (split_start < tot_slots);
const bool is_last_split = (split_end == tot_slots);

if (!is_active_split) return;

Expand Down