Skip to content

Conversation

@wxsIcey
Copy link
Contributor

@wxsIcey wxsIcey commented Sep 25, 2025

Purpose

Fix TritonLanguagePlaceholder missing tensor attribute, this is because TritonLanguagePlaceholder does not have a tensor attribute, but compute_identity_kernel in fused_moe.py uses tl.tensor

Test Plan

existed CI passed


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the missing tensor attribute to the TritonLanguagePlaceholder class. This is a necessary fix to prevent AttributeError when Triton is not installed. While the change is correct, I've added a comment regarding the corresponding unit tests, which should be updated to ensure this fix is verifiable and to prevent future regressions.

Signed-off-by: Icey <1790571317@qq.com>
@Yikun Yikun added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 25, 2025
Copy link
Contributor

@wangxiyuan wangxiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we hit this error in vllm-ascend. This PR can fix the problem.

Copy link
Collaborator

@Yikun Yikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See vllm-ascend related issue: vllm-project/vllm-ascend#3175 , and introduced by 845adb3. It's same with 6617718, so LGTM

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 25, 2025 10:12
@mergify
Copy link

mergify bot commented Sep 25, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @wxsIcey.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@DarkLight1337
Copy link
Member

DarkLight1337 commented Sep 25, 2025

Oops, I forgot about #25649 which does the same thing. Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants