- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 11k
 
[Triton] Fix TritonLanguagePlaceholder missing tensor attribute #25658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Icey <1790571317@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds the missing tensor attribute to the TritonLanguagePlaceholder class. This is a necessary fix to prevent AttributeError when Triton is not installed. While the change is correct, I've added a comment regarding the corresponding unit tests, which should be updated to ensure this fix is verifiable and to prevent future regressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we hit this error in vllm-ascend. This PR can fix the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See vllm-ascend related issue: vllm-project/vllm-ascend#3175 , and introduced by 845adb3. It's same with 6617718, so LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
| 
           This pull request has merge conflicts that must be resolved before it can be  | 
    
| 
           Oops, I forgot about #25649 which does the same thing. Closing this one  | 
    
Purpose
Fix TritonLanguagePlaceholder missing tensor attribute, this is because TritonLanguagePlaceholder does not have a tensor attribute, but compute_identity_kernel in fused_moe.py uses tl.tensor
Test Plan
existed CI passed
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.