Skip to content

Conversation

@wdhongtw
Copy link
Contributor

@wdhongtw wdhongtw commented Sep 25, 2025

PR #23991 use another attribute from triton.language, which cause import error in TPU setup.

Enhance the placeholder for TPU environment.

Purpose

Make TPU accelerator setup working again.

Test Plan

Test locally.

Test Result

Pass.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

PR vllm-project#23991 use another attribute from triton.language, which cause
import error in TPU setup.

Enhance the placeholder for TPU environment.

Signed-off-by: Weida Hong <wdhongtw@google.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an import error on TPU environments by adding the tensor attribute to the TritonLanguagePlaceholder. This is a necessary fix to support code that uses triton.language.tensor when Triton is not available. The change is correct, minimal, and directly resolves the issue described. I see no issues with this implementation.

@wdhongtw
Copy link
Contributor Author

Duplicated of #25649 and #25658, closed.

@wdhongtw wdhongtw closed this Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant