Skip to content

Conversation

@LucasWilkinson
Copy link
Collaborator

@LucasWilkinson LucasWilkinson commented Oct 2, 2025

Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
@mergify mergify bot added the ci/build label Oct 2, 2025
@ProExpertProg ProExpertProg enabled auto-merge (squash) October 2, 2025 16:48
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 2, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vllm-flash-attn dependency to a newer commit to incorporate fixes for building with recent CUDA versions. The change is correct and necessary. My review includes one suggestion to improve the long-term maintainability of the build configuration by adding a comment to explain the purpose of the new commit hash, as using raw commit hashes without context can make future updates and debugging more difficult.

vllm-flash-attn
GIT_REPOSITORY https://github.com/vllm-project/flash-attention.git
GIT_TAG 4695e6bed5366c41e28c06cd86170166e4f43d00
GIT_TAG 45b5dac5497e848d788af686bb68cbe5cf2e56bc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using a raw commit hash for a dependency makes it difficult to understand what version is being used and why it was chosen. This can complicate future maintenance and updates. It is a best practice to use version tags for dependencies. If a tag is not available for this commit, please add a comment explaining what this commit hash corresponds to (e.g., what features or fixes it includes) and why it was chosen. This will improve the maintainability of the build system.

          # Pick up fixes for CUDA 12.4 (GH#95) and 12.5 (GH#96)
          GIT_TAG 45b5dac5497e848d788af686bb68cbe5cf2e56bc

@johnnynunez
Copy link
Contributor

super! thank you guys!

@johnnynunez
Copy link
Contributor

@LucasWilkinson @ProExpertProg @mgoin could you review this? #26098

@johnnynunez
Copy link
Contributor

@ProExpertProg i don't know why is it failing, because im using it on my gh200/thor and compiles and works well

@jmkuebler
Copy link
Contributor

@LucasWilkinson can you make sense of the logs? I can't relate it to the changes that are being picked up.

@ProExpertProg
Copy link
Collaborator

Can someone try to reproduce the CI failures? It might just be flaky tests

@jmkuebler
Copy link
Contributor

@ProExpertProg I installed the fork from source (to really make it pick up the FA3 changes) and reran the two tests that failed:

So I think this PR is not the issue here. Can we restart the test or overwrite?

@mgoin
Copy link
Member

mgoin commented Oct 9, 2025

@mergify
Copy link

mergify bot commented Oct 9, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @LucasWilkinson.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Oct 9, 2025
@LucasWilkinson
Copy link
Collaborator Author

superseded by: #25049

auto-merge was automatically disabled October 9, 2025 16:46

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build needs-rebase ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants