Skip to content

[FA/Chore] Bump FA version #26109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[FA/Chore] Bump FA version #26109

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5995bc
bump
LucasWilkinson Oct 2, 2025
5002594
Merge branch 'main' into lwilkinson/bump-fa-2
ProExpertProg Oct 3, 2025
749015b
Merge branch 'main' into lwilkinson/bump-fa-2
ProExpertProg Oct 3, 2025
cb9c5d6
Merge remote-tracking branch 'origin/main' into lwilkinson/bump-fa-3
LucasWilkinson Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/external_projects/vllm_flash_attn.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ else()
FetchContent_Declare(
vllm-flash-attn
GIT_REPOSITORY https://github.com/vllm-project/flash-attention.git
GIT_TAG 4695e6bed5366c41e28c06cd86170166e4f43d00
GIT_TAG 45b5dac5497e848d788af686bb68cbe5cf2e56bc
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using a raw commit hash for a dependency makes it difficult to understand what version is being used and why it was chosen. This can complicate future maintenance and updates. It is a best practice to use version tags for dependencies. If a tag is not available for this commit, please add a comment explaining what this commit hash corresponds to (e.g., what features or fixes it includes) and why it was chosen. This will improve the maintainability of the build system.

          # Pick up fixes for CUDA 12.4 (GH#95) and 12.5 (GH#96)
          GIT_TAG 45b5dac5497e848d788af686bb68cbe5cf2e56bc

GIT_PROGRESS TRUE
# Don't share the vllm-flash-attn build between build types
BINARY_DIR ${CMAKE_BINARY_DIR}/vllm-flash-attn
Expand Down