[Model] Use merge_by_field_config for MM models (Llava family)
#26280
+99
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
added
the
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a nice refactoring that standardizes multi-modal input processing for the Llava family of models by enabling merge_by_field_config. This change simplifies the model-specific code by removing boilerplate for input validation and flattening, which improves maintainability. It also enables new functionality, such as multi-video support for LlavaNextVideoForConditionalGeneration. The only concern is the addition of trust_remote_code=True in the example file, which poses a security risk. I've added a comment to suggest adding a warning for users.
13 tasks
Isotr0py
approved these changes
Oct 6, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
karan
pushed a commit
to karan/vllm
that referenced
this pull request
Oct 6, 2025
…m-project#26280) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Karan Goel <3261985+karan@users.noreply.github.com>
southfreebird
pushed a commit
to southfreebird/vllm
that referenced
this pull request
Oct 7, 2025
…m-project#26280) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…m-project#26280) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…m-project#26280) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…m-project#26280) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…m-project#26280) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…m-project#26280) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Part of #26149
Also:
Enable multi-video input for LLaVA-NeXT-VideoTest Plan
Tested all models other than MiniMax-VL (OOM on my setup)
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.