-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
Closed
Labels
feature requestNew feature or requestNew feature or requestmulti-modalityRelated to multi-modality (#4194)Related to multi-modality (#4194)
Description
🚀 The feature, motivation and pitch
Implement #25676 for each MM model so input shapes are the same as their HF implementations, i.e. no need to use flatten_bn anymore.
I'm going through the list in mostly alphabetical order:
- [Model] Use
merge_by_field_configfor MM models (A-C) #26073 - [Model] Use
merge_by_field_configfor MM models (D-F) #26076 - [Model] Use
merge_by_field_configfor MM models (G) #26117 - [Model] Use
merge_by_field_configfor MM models (InternVL family) #26153 - [Model] Use
merge_by_field_configfor MM models (H-L) #26230 - [Model] Use
merge_by_field_configfor MM models (Llava family) #26280 - [Model] Use merge_by_field_config for MM models (M-N) #26710
- [Model] Use merge_by_field_config for MM models (O-P) #26776
- [Model] Use
merge_by_field_configfor MM models (Ovis family) #26308 - [Model] Use merge_by_field_config for MM models (M-N) #26710
- [Model] Define merge_by_field_config MM interface (R-T) #26260
- [Model] Define merge_by_field_config MM interface (U-Z) #26261
After all models have been migrated, I will try to merge TensorSchema with MultiModalFieldConfig so we can apply validation inside processor instead of model forward pass (which is the critical path)
Alternatives
No response
Additional context
No response
Before submitting a new issue...
- Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
Metadata
Metadata
Assignees
Labels
feature requestNew feature or requestNew feature or requestmulti-modalityRelated to multi-modality (#4194)Related to multi-modality (#4194)
Type
Projects
Status
Done