Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Oct 27, 2025

Purpose

CLOSE #26149

Test Plan

The tensor schema tests passed locally (Qwen3 series isn't tested in CI yet). I have also run the example scripts for each model (except for Qwen3-Omni because it doesn't have one)

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 27, 2025
@DarkLight1337 DarkLight1337 requested review from Isotr0py and ywang96 and removed request for sighingnow October 27, 2025 03:18
@mergify mergify bot added the qwen Related to Qwen models label Oct 27, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the multi-modal input handling for Qwen series models by leveraging the merge_by_field_config mechanism. This is a good improvement as it centralizes the input processing logic, removes redundant code (like _validate_and_reshape_mm_tensor methods) from individual model files, and makes the codebase cleaner and more maintainable. The changes across qwen2_5_omni_thinker.py, qwen2_5_vl.py, qwen2_audio.py, qwen2_vl.py, qwen3_omni_moe_thinker.py, qwen3_vl.py, and qwen_vl.py are consistent with this goal.

I've found one issue that needs to be addressed before merging.

@Isotr0py Isotr0py enabled auto-merge (squash) October 27, 2025 05:18
@Isotr0py Isotr0py merged commit cbd5e07 into vllm-project:main Oct 27, 2025
55 checks passed
@DarkLight1337 DarkLight1337 deleted the merge-by-field-config-qwen branch October 27, 2025 05:45
xuhaolei pushed a commit to ZJU-REAL/EasySteer-vllm-v1 that referenced this pull request Oct 27, 2025
ilmarkov pushed a commit to neuralmagic/vllm that referenced this pull request Nov 7, 2025
ZhengHongming888 pushed a commit to ZhengHongming888/vllm that referenced this pull request Nov 8, 2025
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tracking Issue]: Use merge_by_field_config for MM models

2 participants