[KVConnector] Add metrics to Prometheus-Grafana dashboard #26811
+365
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLucche
requested review from
WoosukKwon,
alexm-redhat,
comaniac,
njhill,
robertgshaw2-redhat and
ywang96
as code owners
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
markmc
suggested changes
Oct 24, 2025
There was a problem hiding this comment.
Hey @NickLucche
I wanted to make sure the per-connector metrics was going to work out. I didn't feel good about adding a bunch of NIXL-specific metrics into vllm/v1/metrics. So I worked it out at NickLucche/pull/4
Couple of small inline comments on buckets too 👍
vllm/v1/metrics/loggers.py
Outdated
| nixl_histogram_post_time, engine_indexes, model_name | ||
| ) | ||
| # uniform 2kb to 16gb range | ||
| buckets = [2**10 + i for i in range(1, 24, 2)] |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
vllm/v1/metrics/loggers.py
Outdated
| name="vllm:nixl_post_time_seconds", | ||
| documentation="Histogram of transfer post time for NIXL KV" | ||
| " Cache transfers.", | ||
| buckets=buckets[1:], |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
[NIXL][Metrics] Add abstraction for per-connector Prometheus metrics
It's post times that need the smaller bucket size, not transfer duration. Uniform 2kb to 16gb range: ``` >>> def human_size(bytes, units=[' bytes','KB','MB','GB','TB', 'PB', 'EB']): ... """ Returns a human readable string representation of bytes """ ... return str(bytes) + units[0] if bytes < 1024 else human_size(bytes>>10, units[1:]) ... >>> [human_size(2**(10+i)) for i in range(1, 25, 2)] ['2KB', '8KB', '32KB', '128KB', '512KB', '2MB', '8MB', '32MB', '128MB', '512MB', '2GB', '8GB'] ``` Signed-off-by: Mark McLoughlin <markmc@redhat.com>
[NIXL][Metrics] Fix NIXL buckets
…ctor Signed-off-by: Mark McLoughlin <markmc@redhat.com>
[KV Connector][Metrics] Add prometheus metrics support to multi-connector
markmc
approved these changes
Oct 28, 2025
NickLucche
changed the title
simon-mo
approved these changes
Oct 28, 2025
github-actions
bot
added
the
ready
MatthewBonanni
pushed a commit
to MatthewBonanni/vllm
that referenced
this pull request
Oct 30, 2025
…ct#26811) Signed-off-by: NickLucche <nlucches@redhat.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com> Co-authored-by: Mark McLoughlin <markmc@redhat.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to the work and discussion in this PR #22188.
Here we expose the metrics we're currently tracking for the nixl connector to prometheus.
cc @markmc
Update:
@markmc generalized the PR to work for KVConnectorStats more broadly